Skip to content

Commit

Permalink
Added the Volumelimits for Powermax (#240)
Browse files Browse the repository at this point in the history
Co-authored-by: Yamunadevi N Shanmugam <[email protected]>
  • Loading branch information
tssushma and shanmydell authored Aug 4, 2023
1 parent 78a1fee commit e43782c
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
6 changes: 4 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# These are the default owners for the code and will
# be requested for review when someone opens a pull request.
# order is alphabetical for easier maintenance.
# Order is alphabetical for easier maintenance.
#
# Sean Gallacher (gallacher)
# Trevor Dawe (tdawe)
Expand All @@ -18,11 +18,13 @@
# Niranjan N (niranjan-n1)
# Shayna Finocchiaro (shaynafinocchiaro)
# Sharmila Ramamoorthy (sharmilarama)
# Sushma T S(tssushma)
# Tao He (taohe1012)
# Peter Cao (P-Cao)
# Yamunadevi Shanmugam(shanmydell)
# Yiming Bao (baoy1)
# Yian Zong (YianZong)
# Forrest Xia (forrestxia)

# for all files:
* @gallacher @tdawe @alikdell @atye @hoppea2 @chaganti-rajitha @coulof @meggm @niranjan-n1 @shaynafinocchiaro @sharmilarama @taohe1012 @P-Cao @baoy1 @YianZong @forrestxia
* @gallacher @tdawe @alikdell @atye @hoppea2 @chaganti-rajitha @coulof @meggm @niranjan-n1 @shaynafinocchiaro @sharmilarama @tssushma @taohe1012 @P-Cao @shanmydell @baoy1 @YianZong @forrestxia
2 changes: 1 addition & 1 deletion charts/container-storage-modules/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ csi-powermax:
- endpoint: https://backup-1.unisphe.re:8443
# - endpoint: https://primary-2.unisphe.re:8443
# - endpoint: https://backup-2.unisphe.re:8443
version: "v2.7.0"
version: "v2.8.0"
images:
driverRepository: "dellemc"
clusterPrefix: ABC
Expand Down
11 changes: 6 additions & 5 deletions charts/csi-powermax/templates/node.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if or (eq .Values.migration.enabled true) (eq .Values.openshift true) }}
apiVersion: v1
kind: ServiceAccount
metadata:
Expand All @@ -14,6 +13,9 @@ metadata:
name: {{ .Release.Name }}-node
{{- end }}
rules:
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get", "list", "watch", "update", "patch"]
{{- if eq .Values.openshift true }}
- apiGroups: ["security.openshift.io"]
resources: ["securitycontextconstraints"]
Expand Down Expand Up @@ -60,7 +62,6 @@ roleRef:
{{- end }}
apiGroup: rbac.authorization.k8s.io
---
{{ end }}
kind: DaemonSet
apiVersion: apps/v1
metadata:
Expand All @@ -81,9 +82,7 @@ spec:
labels:
app: {{ .Release.Name }}-node
spec:
{{- if or (eq .Values.migration.enabled true) (eq .Values.openshift true) }}
serviceAccountName: {{ .Release.Name }}-node
{{ end }}
{{ if .Values.node.nodeSelector }}
nodeSelector:
{{- toYaml .Values.node.nodeSelector | nindent 8 }}
Expand Down Expand Up @@ -121,6 +120,8 @@ spec:
value: unix://{{ .Values.kubeletConfigDir }}/plugins/powermax.emc.dell.com/csi_sock
- name: X_CSI_MODE
value: node
- name: X_CSI_MAX_VOLUMES_PER_NODE
value: "{{ .Values.maxPowerMaxVolumesPerNode }}"
- name: X_CSI_PRIVATE_MOUNT_DIR
value: "{{ .Values.kubeletConfigDir }}/plugins/powermax.emc.dell.com/disks"
- name: X_CSI_MANAGED_ARRAYS
Expand Down Expand Up @@ -395,4 +396,4 @@ spec:
secret:
secretName: proxy-server-root-certificate
{{ end }}
{{ end }}
{{ end }}
9 changes: 8 additions & 1 deletion charts/csi-powermax/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ global:

# Current version of the driver
# Don't modify this value as this value will be used by the install script
version: "v2.7.0"
version: "v2.8.0"

images:
# "driver" defines the container image, used for the driver container.
Expand Down Expand Up @@ -101,6 +101,13 @@ kubeletConfigDir: /var/lib/kubelet
# Default value: ReadWriteOnceWithFSType
fsGroupPolicy: ReadWriteOnceWithFSType

# maxPowermaxVolumesPerNode: Specify default value for maximum number of volumes that controller can publish to the node.
# If value is zero CO SHALL decide how many volumes of this type can be published by the controller to the node.
# This limit is applicable to all the nodes in the cluster for which node label 'max-Powermax-volumes-per-node' is not set.
# Allowed values: n, where n >= 0
# Default value: 0
maxPowerMaxVolumesPerNode: 0

# controller: configure controller specific parameters
controller:
# controllerCount: Define the number of PowerMax controller nodes
Expand Down

0 comments on commit e43782c

Please sign in to comment.