Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tls issues #54

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fixing tls issues #54

merged 1 commit into from
Aug 28, 2024

Conversation

kumarkgosa
Copy link
Contributor

@kumarkgosa kumarkgosa commented Aug 28, 2024

Description

Min Version is added to tls to remove weakness.
Nosec comment was added to remove the false positive where the insecureSkipverify was set to true

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Integration tests were run, and it worked perfectly. Ran the GoSec scan to make sure we fixed the issue

problem
solved

@kumarkgosa kumarkgosa merged commit 348bace into main Aug 28, 2024
5 checks passed
@kumarkgosa kumarkgosa deleted the tls-update branch August 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants