Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: CSI 1.6 - maximum volume size #45

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Conversation

mdutka-dell
Copy link
Contributor

@mdutka-dell mdutka-dell commented Oct 19, 2023

Description

Adding maximum volume size funtionality in message GetCapacityResponse

The PR does not fix golangci-lint issues

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests

Output from added unit tests getMaxVolumeSizeTest in TestVolume suite:
{"Time":"2023-10-25T04:24:23.000678077-04:00","Action":"output","Package":"github.com/dell/gounity","Test":"TestVolume","Output":"Begin - Get Max Volume Size\n"} {"Time":"2023-10-25T04:24:23.654261282-04:00","Action":"output","Package":"github.com/dell/gounity","Test":"TestVolume","Output":"time=\"2023-10-25T04:24:23-04:00\" level=error msg=\"failed to invoke Unity REST API server\" func=\"github.com/dell/gounity.(*Client).executeWithRetryAuthenticate()\" file=\"/home/gosia/repos/gounity/unityclient.go:149\" error=\"[{The requested resource does not exist. (Error Code:0x7d13005)}]\"\n"} {"Time":"2023-10-25T04:24:23.654297953-04:00","Action":"output","Package":"github.com/dell/gounity","Test":"TestVolume","Output":"Get Max Volume Size - Successful\n"}

@mdutka-dell mdutka-dell changed the title CSI 1.6 feature: CSI 1.6 - maximum volume size Oct 24, 2023
@mdutka-dell mdutka-dell marked this pull request as ready for review October 25, 2023 08:58
volume.go Outdated Show resolved Hide resolved
Copy link
Contributor

@panigs7 panigs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mdutka-dell mdutka-dell merged commit 1f3e9f0 into main Oct 27, 2023
1 check failed
@anandrajak1 anandrajak1 deleted the maximum-volume-size branch October 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants