Authorization v2 update storage crd to have isiPath for PowerScale support

[alikdell]

Description

Authorization v2 update storage crd to have isiPath for PowerScale support.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#1281

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

• ################End Reconcile##############
  --- PASS: TestCustom (56.43s)
  --- PASS: TestCustom/TestAppMobPreCheckError (0.00s)
  --- PASS: TestCustom/TestAppMobReconcile (0.87s)
  --- PASS: TestCustom/TestAuthorizationServerPreCheck (20.85s)
  --- PASS: TestCustom/TestAuthorizationServerReconcile (20.87s)
  --- PASS: TestCustom/TestAuthorizationServerReconcileOCP (0.71s)
  --- PASS: TestCustom/TestContentWatch (0.00s)
  --- PASS: TestCustom/TestCsmDowngrade (0.03s)
  --- PASS: TestCustom/TestCsmDowngradePathInvalid (0.00s)
  --- PASS: TestCustom/TestCsmDowngradeSkipVersion (0.02s)
  --- PASS: TestCustom/TestCsmDowngradeVersionTooOld (0.00s)
  --- PASS: TestCustom/TestCsmFinalizerError (0.00s)
  --- PASS: TestCustom/TestCsmPreCheckModuleError (0.00s)
  --- PASS: TestCustom/TestCsmPreCheckModuleUnsupportedVersion (0.00s)
  --- PASS: TestCustom/TestCsmPreCheckTypeError (0.00s)
  --- PASS: TestCustom/TestCsmPreCheckVersionError (0.00s)
  --- PASS: TestCustom/TestCsmUpgrade (0.05s)
  --- PASS: TestCustom/TestCsmUpgradePathInvalid (0.00s)
  --- PASS: TestCustom/TestCsmUpgradeSkipVersion (0.04s)
  --- PASS: TestCustom/TestCsmUpgradeVersionTooOld (0.00s)
  --- PASS: TestCustom/TestDeleteErrorReconcile (0.20s)
  --- PASS: TestCustom/TestErrorInjection (0.43s)
  --- PASS: TestCustom/TestIgnoreUpdatePredicate (0.00s)
  --- PASS: TestCustom/TestOldStandAloneModuleCleanup (0.29s)
  --- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success_-Disable_Components (0.02s)
  --- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-Enable_all_modules (0.02s)
  --- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-_Disable_all_modules (0.25s)
  --- PASS: TestCustom/TestPowerFlexAnnotation (0.00s)
  --- PASS: TestCustom/TestPowerScaleAnnotation (0.00s)
  --- PASS: TestCustom/TestPowerStoreAnnotation (0.00s)
  --- PASS: TestCustom/TestPowermaxAnnotation (0.00s)
  --- PASS: TestCustom/TestPowermaxReconcileError (0.00s)
  --- PASS: TestCustom/TestReconcile (0.21s)
  --- PASS: TestCustom/TestReconcileAppMob (0.00s)
  --- PASS: TestCustom/TestReconcileAuthorization (0.00s)
  --- PASS: TestCustom/TestReconcileAuthorizationBadCert (10.27s)
  --- PASS: TestCustom/TestReconcileError (0.00s)
  --- PASS: TestCustom/TestReconcileObservabilityError (0.00s)
  --- PASS: TestCustom/TestReconcileObservabilityErrorBadCert (0.01s)
  --- PASS: TestCustom/TestReconcileObservabilityErrorBadComponent (0.00s)
  --- PASS: TestCustom/TestReconcileReverseProxyError (0.00s)
  --- PASS: TestCustom/TestReconcileReverseProxyServiceError (0.00s)
  --- PASS: TestCustom/TestRemoveDriver (0.61s)
  --- PASS: TestCustom/TestRemoveDriver/getDriverConfig_error (0.00s)
  --- PASS: TestCustom/TestRemoveDriver/getDriverConfig_no_driver (0.00s)
  --- PASS: TestCustom/TestRemoveDriver/delete_obj_not_found (0.02s)
  --- PASS: TestCustom/TestRemoveDriver/get_SA_error (0.07s)
  --- PASS: TestCustom/TestRemoveDriver/get_CR_error (0.06s)
  --- PASS: TestCustom/TestRemoveDriver/get_CRB_error (0.07s)
  --- PASS: TestCustom/TestRemoveDriver/get_CM_error (0.10s)
  --- PASS: TestCustom/TestRemoveDriver/get_Driver_error (0.09s)
  --- PASS: TestCustom/TestRemoveDriver/delete_SA_error (0.08s)
  --- PASS: TestCustom/TestRemoveDriver/delete_Daemonset_error (0.07s)
  --- PASS: TestCustom/TestRemoveDriver/delete_Deployment_error (0.06s)
  --- PASS: TestCustom/TestRemoveModule (0.44s)
  --- PASS: TestCustom/TestRemoveModule/csm (0.23s)
  --- PASS: TestCustom/TestRemoveModule/csm#01 (0.20s)
  --- PASS: TestCustom/TestRemoveModule/csm#02 (0.00s)
  --- PASS: TestCustom/TestResiliencyReconcile (0.10s)
  --- PASS: TestCustom/TestResiliencyReconcileError (0.00s)
  --- PASS: TestCustom/TestReverseProxyPreCheckError (0.00s)
  --- PASS: TestCustom/TestReverseProxyReconcile (0.11s)
  --- PASS: TestCustom/TestSyncCSM (0.30s)
  --- PASS: TestCustom/TestSyncCSM/auth_proxy_server_bad_op_conf (0.00s)
  --- PASS: TestCustom/TestSyncCSM/app_mobility_happy_path (0.30s)
  --- PASS: TestCustom/TestSyncCSM/app_mobility_bad_op_conf (0.00s)
  --- PASS: TestCustom/TestSyncCSM/reverse_proxy_server_bad_op_conf (0.00s)
  --- PASS: TestCustom/TestSyncCSM/getDriverConfig_bad_op_config (0.00s)
  --- PASS: TestCustom/TestSyncCSM/getDriverConfig_error (0.00s)
  --- PASS: TestCustom/TestUnityAnnotation (0.00s)
  PASS
  coverage: 90.1% of statements in github.com/dell/csm-operator/pkg/logger, github.com/dell/csm-operator/pkg/resources/daemonset, github.com/dell/csm-operator/pkg/resources/deployment, github.com/dell/csm-operator/pkg/resources/statefulset, github.com/dell/csm-operator/pkg/resources/configmap, github.com/dell/csm-operator/pkg/resources/serviceaccount, github.com/dell/csm-operator/pkg/resources/rbac, github.com/dell/csm-operator/pkg/resources/csidriver, github.com/dell/csm-operator/pkg/constants, github.com/dell/csm-operator/controllers
  ok github.com/dell/csm-operator/controllers 56.833s coverage: 90.1% of statements in github.com/dell/csm-operator/pkg/logger, github.com/dell/csm-operator/pkg/resources/daemonset, github.com/dell/csm-operator/pkg/resources/deployment, github.com/dell/csm-operator/pkg/resources/statefulset, github.com/dell/csm-operator/pkg/resources/configmap, github.com/dell/csm-operator/pkg/resources/serviceaccount, github.com/dell/csm-operator/pkg/resources/rbac, github.com/dell/csm-operator/pkg/resources/csidriver, github.com/dell/csm-operator/pkg/constants, github.com/dell/csm-operator/controllers

[kumarp20]

Could more details be added to the PR description as to why the isiPath attribute is being added to the CRD ? Since this is a powerscale specific attribute, can a description be added for the attribute, so a user can understand the purpose of the attribute by doing kubectl explain storages ? Actually could such descriptions be added for all attributes of the storage CRD and other Auth 2.0 related CRDs ?

Request for similar changes in csm-authorization repo as well. Added a comment in PR #83 for that repo.

For eg: see the app-mo CRDs here: https://eos2git.cec.lab.emc.com/CSM/csm-application-mobility/blob/main/config/crd/bases/mobility.storage.dell.com_backups.yaml#L206

[shaynafinocchiaro]

@kumarp20 Descriptions have been added to the authorization types.