Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR, do not merge: disable sdc-monito and health-monitor by default #653

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

kumarp20
Copy link

@kumarp20 kumarp20 commented Aug 8, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@kumarp20 kumarp20 changed the title disable sdc-monito and health-monitor by default Draft PR: disable sdc-monito and health-monitor by default Aug 8, 2024
@kumarp20 kumarp20 changed the title Draft PR: disable sdc-monito and health-monitor by default Draft PR, do not merge: disable sdc-monito and health-monitor by default Aug 8, 2024
@harishp8889 harishp8889 changed the base branch from main to minimal-manifests-poc August 8, 2024 10:34
@harishp8889 harishp8889 merged commit 86e8f93 into minimal-manifests-poc Aug 8, 2024
6 of 9 checks passed
@mjsdell mjsdell deleted the pflex-minimal branch October 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants