Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSMVersion annotation to operator controller-manager pod #492

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

jooseppi-luna
Copy link
Contributor

@jooseppi-luna jooseppi-luna commented Feb 22, 2024

Description

Add an annotation to the csm-operator controller-manager pod giving the CSM version for the installed operator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1091

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Did a kubectl describe on the controller-manager pod and confirmed CSM Version label exists now. Also confirmed that upgrading operators also updates the annotation by setting the label to 1.9.0 and updating it to v1.10.0. See output of the successful install and the storage.dell.com/CSMVersion: v1.10.0 annotation now present:

[root@master-1-Zaglt7mQUY8Wg csm-operator]# kubectl describe pod -n dell-csm-operator   dell-csm-operator-controller-manager-6b5fc4bcbf-tvftx
Name:             dell-csm-operator-controller-manager-6b5fc4bcbf-tvftx
Namespace:        dell-csm-operator
Priority:         0
Service Account:  dell-csm-operator-manager-service-account
Node:             worker-1-zaglt7mquy8wg.domain/10.247.101.227
Start Time:       Thu, 22 Feb 2024 17:30:46 -0500
Labels:           control-plane=controller-manager
                  pod-template-hash=6b5fc4bcbf
Annotations:      storage.dell.com/CSMVersion: v1.10.0
Status:           Running
IP:               10.244.1.75
IPs:
  IP:           10.244.1.75
Controlled By:  ReplicaSet/dell-csm-operator-controller-manager-6b5fc4bcbf
Containers:
...

@jooseppi-luna jooseppi-luna merged commit 8310d41 into main Feb 23, 2024
8 checks passed
jooseppi-luna added a commit that referenced this pull request Feb 27, 2024
* add CSMVersion to controller-manager

* use annotation instead of label
@alikdell alikdell deleted the add-CSMVersion-to-operator-pod branch March 28, 2024 12:24
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* add CSMVersion to controller-manager

* use annotation instead of label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants