update golangci-lint #456
Merged
update golangci-lint #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbartoszDell
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
atye,
sharmilarama and
shanmydell
as code owners
shaynafinocchiaro
previously approved these changes
Feb 8, 2024
cbartoszDell
commented
Feb 8, 2024
donatwork
requested changes
Feb 13, 2024
KerryKovacevic
previously approved these changes
Feb 13, 2024
cbartoszDell
force-pushed
the
golangci-lint
branch
from
3c917d9
to
babe14f
Compare
|
This PR is only for upgrading the versions on Go and golangci-lint action. This is required to make sure that golangci-lint is always the latest version and is working with the latest version of Go. This requests is being made to all CSM drivers and modules to make sure linter action keeps working. Fixing linter warnings is not a part of scope of this upgrade PR. Also, @donatwork FYI since I opened this PR 5 other PRs got merged with |
donatwork
previously approved these changes
Feb 15, 2024
jooseppi-luna
approved these changes
Feb 22, 2024
nitesh3108
approved these changes
Feb 22, 2024
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* update golangci-lint * remove extraneous append * outdent else * outdent else * fmt fixes (#486) --------- Co-authored-by: Jooseppi Luna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of golangci-lint and go version used in linters actions.