Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App mob cert yamls #342

Closed
wants to merge 29 commits into from
Closed

Conversation

mbasha-dell
Copy link
Contributor

@mbasha-dell mbasha-dell commented Aug 31, 2023

Description

Created issuer and certificate deployment for AM cert-manager use

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Ran & increased unit test coverage to 91.2%
image
  • Successfully created backup via dellctl. Also tried a restore, which did not work. This will be resolved by updated the AM image to a version that supports Velero 1.10.0
image

@mbasha-dell mbasha-dell closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants