Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prerequisites link in readme #334

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Fix prerequisites link in readme #334

merged 4 commits into from
Aug 29, 2023

Conversation

panigs7
Copy link
Collaborator

@panigs7 panigs7 commented Aug 28, 2023 •
edited
Loading

Description

This PR fixes a broken link in /test/README.md. Also, it fixes the maxVxflexosVolumesPerNode default value
Updated UBI 9.2-13 image as well

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Tested the link
UBI 9 image tested - Sanity
image

jooseppi-luna
jooseppi-luna previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the link fix

@panigs7 panigs7 merged commit 7ba8e9f into main Aug 29, 2023
7 of 8 checks passed
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Fix prerequisites link in readme (#334)
246e62c 
* fix prerequisites link in readme

* Address review comments

* Update storage_csm_powerflex_v280.yaml

* update ubi image
@mjsdell mjsdell deleted the fix-readme-link branch October 17, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panigs7 @jooseppi-luna @rensyct @karthikk92