Fix e2e with new yamls and support restic again #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve merge conflict errors
kumarkgosa
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
bandak2,
mjsdell,
rajendraindukuri,
rensyct and
panigs7
as code owners
kumarkgosa
requested review from
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
jooseppi-luna
approved these changes
Aug 24, 2023
abhi16394
requested changes
Aug 24, 2023
mbasha-dell
approved these changes
Aug 24, 2023
mbasha-dell
approved these changes
Aug 24, 2023
jooseppi-luna
added a commit
that referenced
this pull request
Dec 6, 2023
* App mob support (#265) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * uncomment cr steps in e2e tests * Add e2e scenario for bad_license --------- Co-authored-by: root <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update values.yaml with appmob-e2e changes * Merging App controller manager branch to a unified app-mob branch (#273) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * install deployment * Adding reconcile method * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * Adding reconcile function * added app mobility webhook unit test * fix issue with test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * bring unit-test coverage up * coverage up to 90.5% * Adding cert files * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * uncomment cr steps in e2e tests * install deployment * Adding reconcile method * Adding reconcile function * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * added app mobility webhook unit test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * Adding cert files * bring unit-test coverage up * Deployment changes * coverage up to 90.5% * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * deployment method * Add velero crds all-in-one yaml * App-mob deployment pods * Fix comment errors and cert secret name * Add velero installation support * Placing velero-secret in samples --------- Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> * added AM cert manager e2e test * Make e2e work * e2e tests for app-mob * syntax fix * syntax fixes * removed redundant cert-manager installation in a test case * Adding e2e for velero and app-mob-controller * e2e syntax fixes * adjusted velero install cmd to make os/exec package happy * working application-mobility e2e * add temporary appmob-values to test * updated app-mob values for e2e * improve app mob pod checking * add helm repo cmd * fix capitalization in appmob-values * all tests running * Add step for helm repo * remove extra --- at bottom of 615 file * Update actions.yml * Controller unit test (#285) * added covergae for controllers removed dead code * trigger actions * go fmt * change velero secret env var name for gosec * get rid of word credential * fix linting errors * fix linting err * add nosec to velero secret name * Update actions.yml * Merging velero features to application-mobility branch (#287) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Application kar (#290) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Init-container inputs from sample file and cover unit-tests (#292) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format * Init container inputs from sample file * Update application_mobility.go * Spell check --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * reverted webhook-server-cert designation to cert-manager-webhook-ca (#298) * Adding restic support (#303) * Application mobility service yamls (#309) * added service and service monitor yaml info for velero deployment * added servicemonitor case to utils GetModuleComponentObj * changed coreos reference path * removed service monitor installation * finish merging main into app-mob branch * Deploy velero-crds and velero secret from sample file (#313) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts --------- Co-authored-by: Jooseppi Luna <[email protected]> * Code cleanup-01 * Fix crd and unit-test (#319) * changed app mob cert manager yaml reference * Velero kar (#320) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error --------- Co-authored-by: Jooseppi Luna <[email protected]> * Removing upgrade CRDs * Formattong issues * cleanup format issue * App mob crds (#325) * create app mobility crds * e2e tests passing * got e2e and unit tests working, e2e output broken * e2e tests working * fixed fmt issues * Fixed ImagePullPolicy for app-mobility (#330) * got imagepullpolicy working * code cleanup * Fix e2e with new yamls and support restic again (#328) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict --------- Co-authored-by: Jooseppi Luna <[email protected]> * modify verify script (#331) * Deploy two init-containers and rename restic to node-agent (#340) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles --------- Co-authored-by: Jooseppi Luna <[email protected]> * some fixes for AM install (#343) * some fixes for AM install * fix out-dated code * App mob status (#345) * fix conflicts * changing variable to camelcase * Review changes * review comment changes * Keeping CRDs alive after deleting csm application-mobility (#349) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml --------- Co-authored-by: Jooseppi Luna <[email protected]> * Bump up controller unit test coverage for application-mobility branch (#353) * built some more unit tests need to get them passing * got one auth test working * coverage up to 90.5 * go fmt * update configuration provider on velero and vol_snapshot_location (#354) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml * update configuration provider * declare backupURL --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mob cert and issuer deployment (#355) * added issuer and cert use to app-mob * more issuer & cert yaml additions * fixed service cert reference * added issuer & cert to GetModuleComponentObj * Fixed formatting and build issues * fixed cert manager package path * go mod tidy * fixed issuer and cert var references * added cert manager scheme to main * added cert-manager crds * update certificate and controller manager webhook secret name * reverting webhook secret name * switched cert-manager crd to helm yaml * Revert "reverting webhook secret name" This reverts commit 5723d4c. * Reverting cert manager crd * manually applying cert name for testing * reverted issuer cert name * Manually passed in namespace name into inject-ca-from field of appmob crd * plugged namespace parameter back intop appmob crd all * added test for issuer cert service * adding back in Jooseppi's pkg updates * added unit tests for crd & cert-issuer deployment * fix cert manager webhook secert name * create separate secret for webhook server cert * matching secret mounted in AM controller pod with cert * fixed unit tests * update cert manager test to correspond with current app mob yaml names * update go & go mod tidy * switched cert-manager crd to common files * removed extraneous comments * Fixing Linting * fixed module unit test and pr comments * removed cert-crd yaml in place of common cert * removed unused resticcrdmanifest * removed conditions from certificate yaml * removed some metadata labels * AM deployment fixes and updates (#358) * one values file, remove param * fix AM + driver, daemonset status * fix yaml for AM deployed in diff namespace * fix tests * fmt * Changing license for application-mobility (#361) * Add license * unit-test and e2e test updates * Fixing unit-test * updating go.mod file * resolve go.mod conflicts * ran go mod tidy * Addressing comments PR * replacing image * removing amaas image * remove duplicate line --------- Co-authored-by: JacobGros <[email protected]> * Seperated BSL, Removed cleanup crds and handled exception for repeated secret creation (#362) * Seperated BSL, Removed cleanup crds and handled exceptions for repeated secret usage * Changing credentials.enabled to createWithInstall * format changes * unit-test fix * working prechecks * unit-test * test passing * removing license from csm-controller * Removing check for newly created secret * minor check * changing default in secret creation to editable bsl name * fix CM.enabled flag for AM (#373) * fix am disable (#377) * fix am disable * test AM uninstall * PR feedback * Fix am tests (#380) * Go mod updates (#341) * update go.mod * got e2e tests running * all unit tests passing * moved panics down * fixed gosec issues but now unit tests coverage is degraded * bumped coverage to 90.5% * fixed linting issue * go fmt * add AM test pre-req, cherry pick commit * fix first test * add checks to make sure backup/restore delete * fix yaml * make AM tests optional * fix comment * add 2nd test with alt values * make bucket-names changeable, add alt-bucket * fix/update velero * add velero values file for test * fix template issue * add enable and disable test * add module field * add seperate CRs test * clean up values file * update Readme * fix vet issue * go fmt * PR feedback --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mobility v1 (#393) * Upgrading CRD's to V1 * Updating values file * Remove sample files (#412) * finish merge conflicts * e2e tests passing --------- Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Kumar Karthik Gosa <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> Co-authored-by: Kumarkgosa <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: abhi16394 <[email protected]>
jooseppi-luna
added a commit
that referenced
this pull request
Dec 6, 2023
* Application mobility (#419) * App mob support (#265) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * uncomment cr steps in e2e tests * Add e2e scenario for bad_license --------- Co-authored-by: root <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update values.yaml with appmob-e2e changes * Merging App controller manager branch to a unified app-mob branch (#273) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * install deployment * Adding reconcile method * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * Adding reconcile function * added app mobility webhook unit test * fix issue with test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * bring unit-test coverage up * coverage up to 90.5% * Adding cert files * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * uncomment cr steps in e2e tests * install deployment * Adding reconcile method * Adding reconcile function * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * added app mobility webhook unit test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * Adding cert files * bring unit-test coverage up * Deployment changes * coverage up to 90.5% * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * deployment method * Add velero crds all-in-one yaml * App-mob deployment pods * Fix comment errors and cert secret name * Add velero installation support * Placing velero-secret in samples --------- Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> * added AM cert manager e2e test * Make e2e work * e2e tests for app-mob * syntax fix * syntax fixes * removed redundant cert-manager installation in a test case * Adding e2e for velero and app-mob-controller * e2e syntax fixes * adjusted velero install cmd to make os/exec package happy * working application-mobility e2e * add temporary appmob-values to test * updated app-mob values for e2e * improve app mob pod checking * add helm repo cmd * fix capitalization in appmob-values * all tests running * Add step for helm repo * remove extra --- at bottom of 615 file * Update actions.yml * Controller unit test (#285) * added covergae for controllers removed dead code * trigger actions * go fmt * change velero secret env var name for gosec * get rid of word credential * fix linting errors * fix linting err * add nosec to velero secret name * Update actions.yml * Merging velero features to application-mobility branch (#287) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Application kar (#290) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Init-container inputs from sample file and cover unit-tests (#292) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format * Init container inputs from sample file * Update application_mobility.go * Spell check --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * reverted webhook-server-cert designation to cert-manager-webhook-ca (#298) * Adding restic support (#303) * Application mobility service yamls (#309) * added service and service monitor yaml info for velero deployment * added servicemonitor case to utils GetModuleComponentObj * changed coreos reference path * removed service monitor installation * finish merging main into app-mob branch * Deploy velero-crds and velero secret from sample file (#313) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts --------- Co-authored-by: Jooseppi Luna <[email protected]> * Code cleanup-01 * Fix crd and unit-test (#319) * changed app mob cert manager yaml reference * Velero kar (#320) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error --------- Co-authored-by: Jooseppi Luna <[email protected]> * Removing upgrade CRDs * Formattong issues * cleanup format issue * App mob crds (#325) * create app mobility crds * e2e tests passing * got e2e and unit tests working, e2e output broken * e2e tests working * fixed fmt issues * Fixed ImagePullPolicy for app-mobility (#330) * got imagepullpolicy working * code cleanup * Fix e2e with new yamls and support restic again (#328) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict --------- Co-authored-by: Jooseppi Luna <[email protected]> * modify verify script (#331) * Deploy two init-containers and rename restic to node-agent (#340) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles --------- Co-authored-by: Jooseppi Luna <[email protected]> * some fixes for AM install (#343) * some fixes for AM install * fix out-dated code * App mob status (#345) * fix conflicts * changing variable to camelcase * Review changes * review comment changes * Keeping CRDs alive after deleting csm application-mobility (#349) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml --------- Co-authored-by: Jooseppi Luna <[email protected]> * Bump up controller unit test coverage for application-mobility branch (#353) * built some more unit tests need to get them passing * got one auth test working * coverage up to 90.5 * go fmt * update configuration provider on velero and vol_snapshot_location (#354) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml * update configuration provider * declare backupURL --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mob cert and issuer deployment (#355) * added issuer and cert use to app-mob * more issuer & cert yaml additions * fixed service cert reference * added issuer & cert to GetModuleComponentObj * Fixed formatting and build issues * fixed cert manager package path * go mod tidy * fixed issuer and cert var references * added cert manager scheme to main * added cert-manager crds * update certificate and controller manager webhook secret name * reverting webhook secret name * switched cert-manager crd to helm yaml * Revert "reverting webhook secret name" This reverts commit 5723d4c. * Reverting cert manager crd * manually applying cert name for testing * reverted issuer cert name * Manually passed in namespace name into inject-ca-from field of appmob crd * plugged namespace parameter back intop appmob crd all * added test for issuer cert service * adding back in Jooseppi's pkg updates * added unit tests for crd & cert-issuer deployment * fix cert manager webhook secert name * create separate secret for webhook server cert * matching secret mounted in AM controller pod with cert * fixed unit tests * update cert manager test to correspond with current app mob yaml names * update go & go mod tidy * switched cert-manager crd to common files * removed extraneous comments * Fixing Linting * fixed module unit test and pr comments * removed cert-crd yaml in place of common cert * removed unused resticcrdmanifest * removed conditions from certificate yaml * removed some metadata labels * AM deployment fixes and updates (#358) * one values file, remove param * fix AM + driver, daemonset status * fix yaml for AM deployed in diff namespace * fix tests * fmt * Changing license for application-mobility (#361) * Add license * unit-test and e2e test updates * Fixing unit-test * updating go.mod file * resolve go.mod conflicts * ran go mod tidy * Addressing comments PR * replacing image * removing amaas image * remove duplicate line --------- Co-authored-by: JacobGros <[email protected]> * Seperated BSL, Removed cleanup crds and handled exception for repeated secret creation (#362) * Seperated BSL, Removed cleanup crds and handled exceptions for repeated secret usage * Changing credentials.enabled to createWithInstall * format changes * unit-test fix * working prechecks * unit-test * test passing * removing license from csm-controller * Removing check for newly created secret * minor check * changing default in secret creation to editable bsl name * fix CM.enabled flag for AM (#373) * fix am disable (#377) * fix am disable * test AM uninstall * PR feedback * Fix am tests (#380) * Go mod updates (#341) * update go.mod * got e2e tests running * all unit tests passing * moved panics down * fixed gosec issues but now unit tests coverage is degraded * bumped coverage to 90.5% * fixed linting issue * go fmt * add AM test pre-req, cherry pick commit * fix first test * add checks to make sure backup/restore delete * fix yaml * make AM tests optional * fix comment * add 2nd test with alt values * make bucket-names changeable, add alt-bucket * fix/update velero * add velero values file for test * fix template issue * add enable and disable test * add module field * add seperate CRs test * clean up values file * update Readme * fix vet issue * go fmt * PR feedback --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mobility v1 (#393) * Upgrading CRD's to V1 * Updating values file * Remove sample files (#412) * finish merge conflicts * e2e tests passing --------- Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Kumar Karthik Gosa <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> Co-authored-by: Kumarkgosa <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: abhi16394 <[email protected]> * format fixes * updated go.mod * fixed e2e values file env var value * remove internal link remove unused sample file --------- Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Kumar Karthik Gosa <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> Co-authored-by: Kumarkgosa <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: abhi16394 <[email protected]>
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* Application mobility (#419) * App mob support (#265) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * uncomment cr steps in e2e tests * Add e2e scenario for bad_license --------- Co-authored-by: root <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update values.yaml with appmob-e2e changes * Merging App controller manager branch to a unified app-mob branch (#273) * Adding yaml files for app-mobility * Adding additional yamls * added app mob files to pkg/modules * Update application_mobility.go * Update application_mobility_test.go * add app-mob const * returned instance of app mobility module (#190) * App mobility add yamls (#191) * Created YAMLs for supporting Application Mobility * fixed reference to variables in yamls * fixed valero designation * Add a few functions and tests for app-mobility (#196) * adding app mob support * adding app mob support * finished function work * adding app mob support * finished function work * added types etc. now need tests * code for get app mob deployment finished added sample file * removed irrelevant var * added deployment manifest filename * Update application_mobility_test.go * add test for code written so far * Update application_mobility_test.go * removed imports and fixed errors * app mob testing go cleanup * resolved test notifications from go * added app mobility unit test * fix modules unit tests add coverage for app mob --------- Co-authored-by: Abrar Basha <[email protected]> * install deployment * Adding reconcile method * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * Adding reconcile function * added app mobility webhook unit test * fix issue with test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * application-mobility e2e testing framework (#208) * got e2e test working * Update steps_def.go * added replicacount 2 e2e test for reconcileAppMobility --------- Co-authored-by: Abrar Basha <[email protected]> * bring unit-test coverage up * coverage up to 90.5% * Adding cert files * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * uncomment cr steps in e2e tests * install deployment * Adding reconcile method * Adding reconcile function * Add metric service * got webhook manifest and apply/deleted webhook service * removed unnecessary parameters * added app mobility webhook unit test * Added precheck function and unit test * update unit-test * removed unused test file * Fix unit-test * Adding cert files * bring unit-test coverage up * Deployment changes * coverage up to 90.5% * add test files * commented cert-manager code back out * Add velero yamls * Updated velero yamls * deployment method * Add velero crds all-in-one yaml * App-mob deployment pods * Fix comment errors and cert secret name * Add velero installation support * Placing velero-secret in samples --------- Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> * added AM cert manager e2e test * Make e2e work * e2e tests for app-mob * syntax fix * syntax fixes * removed redundant cert-manager installation in a test case * Adding e2e for velero and app-mob-controller * e2e syntax fixes * adjusted velero install cmd to make os/exec package happy * working application-mobility e2e * add temporary appmob-values to test * updated app-mob values for e2e * improve app mob pod checking * add helm repo cmd * fix capitalization in appmob-values * all tests running * Add step for helm repo * remove extra --- at bottom of 615 file * Update actions.yml * Controller unit test (#285) * added covergae for controllers removed dead code * trigger actions * go fmt * change velero secret env var name for gosec * get rid of word credential * fix linting errors * fix linting err * add nosec to velero secret name * Update actions.yml * Merging velero features to application-mobility branch (#287) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Application kar (#290) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Init-container inputs from sample file and cover unit-tests (#292) * problem idenified with client-go * add changes for build (#284) * update appmob * Velero features working and unit-test fixed * Unit-tests covered for velero * Minor changes as per feedback * Minor changes * checks resolving * Update actions.yml lower threshold to 87 to test go 1.20 * Update actions.yml bump back to 90 because 1.19 works * Satisfy Checks * merge changes * merge * upgrade crds * find module by name * format * stpd format * Init container inputs from sample file * Update application_mobility.go * Spell check --------- Co-authored-by: JacobGros <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * reverted webhook-server-cert designation to cert-manager-webhook-ca (#298) * Adding restic support (#303) * Application mobility service yamls (#309) * added service and service monitor yaml info for velero deployment * added servicemonitor case to utils GetModuleComponentObj * changed coreos reference path * removed service monitor installation * finish merging main into app-mob branch * Deploy velero-crds and velero secret from sample file (#313) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts --------- Co-authored-by: Jooseppi Luna <[email protected]> * Code cleanup-01 * Fix crd and unit-test (#319) * changed app mob cert manager yaml reference * Velero kar (#320) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error --------- Co-authored-by: Jooseppi Luna <[email protected]> * Removing upgrade CRDs * Formattong issues * cleanup format issue * App mob crds (#325) * create app mobility crds * e2e tests passing * got e2e and unit tests working, e2e output broken * e2e tests working * fixed fmt issues * Fixed ImagePullPolicy for app-mobility (#330) * got imagepullpolicy working * code cleanup * Fix e2e with new yamls and support restic again (#328) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict --------- Co-authored-by: Jooseppi Luna <[email protected]> * modify verify script (#331) * Deploy two init-containers and rename restic to node-agent (#340) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles --------- Co-authored-by: Jooseppi Luna <[email protected]> * some fixes for AM install (#343) * some fixes for AM install * fix out-dated code * App mob status (#345) * fix conflicts * changing variable to camelcase * Review changes * review comment changes * Keeping CRDs alive after deleting csm application-mobility (#349) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml --------- Co-authored-by: Jooseppi Luna <[email protected]> * Bump up controller unit test coverage for application-mobility branch (#353) * built some more unit tests need to get them passing * got one auth test working * coverage up to 90.5 * go fmt * update configuration provider on velero and vol_snapshot_location (#354) * Deploy velero-crds and velero secret * resolve conflicts * formatting and linting * resolve main-branch conflicts * code cleanup and working secret automation with real data * Update application_mobility.go Resolve merge conflict errors * changed fmt error to log error * use fmt print instead error * Restic changes and update e2e yamls * minor correction in test yaml * working e2e and support restic again * Update alt-velero-secret.yaml * Update application_mobility.go * Removing duplicate test scenario * resolve merge conflict * Deploy two init-containers and rename restic to node-agent * Fix unit-tests * Update the e2e yaml testfiles * Keeping CRDs alive after deleting csm application-mobility * Formatting * adding label application-mobility for appmob crds * Update app-mobility-crds.yaml * update configuration provider * declare backupURL --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mob cert and issuer deployment (#355) * added issuer and cert use to app-mob * more issuer & cert yaml additions * fixed service cert reference * added issuer & cert to GetModuleComponentObj * Fixed formatting and build issues * fixed cert manager package path * go mod tidy * fixed issuer and cert var references * added cert manager scheme to main * added cert-manager crds * update certificate and controller manager webhook secret name * reverting webhook secret name * switched cert-manager crd to helm yaml * Revert "reverting webhook secret name" This reverts commit 5723d4c. * Reverting cert manager crd * manually applying cert name for testing * reverted issuer cert name * Manually passed in namespace name into inject-ca-from field of appmob crd * plugged namespace parameter back intop appmob crd all * added test for issuer cert service * adding back in Jooseppi's pkg updates * added unit tests for crd & cert-issuer deployment * fix cert manager webhook secert name * create separate secret for webhook server cert * matching secret mounted in AM controller pod with cert * fixed unit tests * update cert manager test to correspond with current app mob yaml names * update go & go mod tidy * switched cert-manager crd to common files * removed extraneous comments * Fixing Linting * fixed module unit test and pr comments * removed cert-crd yaml in place of common cert * removed unused resticcrdmanifest * removed conditions from certificate yaml * removed some metadata labels * AM deployment fixes and updates (#358) * one values file, remove param * fix AM + driver, daemonset status * fix yaml for AM deployed in diff namespace * fix tests * fmt * Changing license for application-mobility (#361) * Add license * unit-test and e2e test updates * Fixing unit-test * updating go.mod file * resolve go.mod conflicts * ran go mod tidy * Addressing comments PR * replacing image * removing amaas image * remove duplicate line --------- Co-authored-by: JacobGros <[email protected]> * Seperated BSL, Removed cleanup crds and handled exception for repeated secret creation (#362) * Seperated BSL, Removed cleanup crds and handled exceptions for repeated secret usage * Changing credentials.enabled to createWithInstall * format changes * unit-test fix * working prechecks * unit-test * test passing * removing license from csm-controller * Removing check for newly created secret * minor check * changing default in secret creation to editable bsl name * fix CM.enabled flag for AM (#373) * fix am disable (#377) * fix am disable * test AM uninstall * PR feedback * Fix am tests (#380) * Go mod updates (#341) * update go.mod * got e2e tests running * all unit tests passing * moved panics down * fixed gosec issues but now unit tests coverage is degraded * bumped coverage to 90.5% * fixed linting issue * go fmt * add AM test pre-req, cherry pick commit * fix first test * add checks to make sure backup/restore delete * fix yaml * make AM tests optional * fix comment * add 2nd test with alt values * make bucket-names changeable, add alt-bucket * fix/update velero * add velero values file for test * fix template issue * add enable and disable test * add module field * add seperate CRs test * clean up values file * update Readme * fix vet issue * go fmt * PR feedback --------- Co-authored-by: Jooseppi Luna <[email protected]> * App mobility v1 (#393) * Upgrading CRD's to V1 * Updating values file * Remove sample files (#412) * finish merge conflicts * e2e tests passing --------- Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Kumar Karthik Gosa <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> Co-authored-by: Kumarkgosa <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: abhi16394 <[email protected]> * format fixes * updated go.mod * fixed e2e values file env var value * remove internal link remove unused sample file --------- Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Kumar Karthik Gosa <[email protected]> Co-authored-by: Abrar Basha <[email protected]> Co-authored-by: abhi16394 <[email protected]> Co-authored-by: Kumarkgosa <[email protected]> Co-authored-by: JacobGros <[email protected]> Co-authored-by: abhi16394 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix e2e with new yamls and support restic again