Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds obsv samples for CSI Powermax #299

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Adds obsv samples for CSI Powermax #299

merged 1 commit into from
Aug 31, 2023

Conversation

delldubey
Copy link
Contributor

Description

  • Add Observability for CSI Powermax
  • Add unit tests for powermax related changes in observability.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#908

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Tests
  • Cluster Tests

jooseppi-luna
jooseppi-luna requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some e2e tests for PowerMax + Observability -- write similar tests to what we have for PowerFlex + Obs and PowerScale + Obs
Add cert-manager to yamls as per this PR: #310

If you need any help or want to talk through any of this, hmu on slack

@shanmydell shanmydell self-requested a review August 22, 2023 08:23
shanmydell
shanmydell previously approved these changes Aug 22, 2023
View reviewed changes
@delldubey
Copy link
Contributor Author

Need some e2e tests for PowerMax + Observability -- write similar tests to what we have for PowerFlex + Obs and PowerScale + Obs Add cert-manager to yamls as per this PR: #310

If you need any help or want to talk through any of this, hmu on slack

Added.

shanmydell
shanmydell previously approved these changes Aug 29, 2023
View reviewed changes
boyamurthy
boyamurthy previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jooseppi-luna
jooseppi-luna requested changes Aug 30, 2023
View reviewed changes
pkg/modules/observability.go Outdated
YamlString = string(buf)

otelCollectorAddress := "otel-collector:55680"
pmaxImage := "dellemc/csm-metrics-powermax:v1.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this an empty string instead of a default image value for better error handling

@jooseppi-luna
Copy link
Contributor

jooseppi-luna commented Aug 30, 2023 •
edited
Loading

Other than my one comment everything looks good, if you can address it by 6:00 AM EST/3:30 PM IST tomorrow (August 31st) I can approve

@delldubey delldubey dismissed stale reviews from boyamurthy and shanmydell via 04b3258 August 31, 2023 05:49
@delldubey delldubey force-pushed the feature-obs-csipmax branch 2 times, most recently from 04b3258 to f0363b4 Compare August 31, 2023 07:11
boyamurthy
boyamurthy previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

boyamurthy
boyamurthy approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delldubey
Adds obsv samples for powermax
5a130a1 
Adds unit test for obs for powermax
Adds e2e for powermax
@delldubey delldubey merged commit dbbf9ff into main Aug 31, 2023
7 of 8 checks passed
@santhoshatdell
Copy link
Contributor

It looks operatorconfig/moduleconfig/common/version-values.yaml is not updated for PowerMax + Obs.
Shouldn't we also need karavi-metrics-powermax.yaml file for Obs 1.6.0 ?

+CC @donatwork

image

donatwork
donatwork reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions need updating.

samples/storage_csm_powermax_v280.yaml
- name: observability
# enabled: Enable/Disable observability
enabled: false
configVersion: v1.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be v1.6.0.

samples/storage_csm_powermax_v280.yaml
enabled: false
# image: Defines karavi-topology image. This shouldn't be changed
# Allowed values: string
image: dellemc/csm-topology:v1.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudl be v1.6.0.

@shanmydell shanmydell deleted the feature-obs-csipmax branch June 11, 2024 10:31
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Adds obsv samples for powermax (#299)
4731af1 
Adds unit test for obsv and e2e for powermax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork left review comments

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@delldubey @jooseppi-luna @santhoshatdell @donatwork @shanmydell @boyamurthy