Feature StorageCapacityTracking for Powermax #281

tssushma · 2023-06-26T09:58:06Z

Description

Support storagecapacitytracking feature for PowerMax.

Additional context
This feature helps the scheduler to schedule the pod on a node (satisfying the topology constraints) only if the requested capacity is available on the storage array.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#876

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 90% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Test A
Test B

delldubey · 2023-06-26T13:06:26Z

pkg/drivers/powermax.go

@@ -53,6 +53,8 @@ const (
 	CSIPmaxVsphereHostname = "<X_CSI_VSPHERE_HOSTNAME>"
 	CSIPmaxVsphereHost     = "<X_CSI_VCENTER_HOST>"
 	CSIPmaxChap            = "<X_CSI_POWERMAX_ISCSI_ENABLE_CHAP>"
+	// CSIStorageCapacityEnabled - Storage capacity flag
+	CSIStorageCapacityEnabled = "false"


What is the use of this param?

This parameter is a redundant entry.
Rectified it and removed this from constant list.

delldubey

lgtm

suryagupta4 · 2023-07-04T11:25:22Z

@tssushma We can also give users an option for configuring the capacity-poll-interval
This is done for PowerStore & PowerScale, refer here:
https://github.com/dell/csm-operator/blob/main/samples/storage_csm_powerstore_v270.yaml#L65
https://github.com/dell/csm-operator/blob/main/samples/storage_csm_powerscale_v270.yaml#L249

rensyct · 2023-07-06T07:43:07Z

@tssushma , is this change intended for 2.7 or 2.8 version of the driver

tssushma · 2023-07-07T09:30:10Z

@tssushma , is this change intended for 2.7 or 2.8 version of the driver

@rensyct , Done updating the version to v2.8.
@suryagupta4, Done adding capacity-poll-interval configuration variable for giving the users an option for configuring poll interval.

rensyct · 2023-07-07T13:00:49Z

operatorconfig/driverconfig/powermax/v2.8.0/upgrade-path.yaml

@@ -0,0 +1 @@
+minUpgradePath: v2.6.0


Should be 2.7.0

rensyct · 2023-07-07T13:01:35Z

samples/storage_csm_powermax_v280.yaml

+    forceRemoveDriver: true
+    common:
+      # Image for CSI PowerMax driver v2.7.0
+      image: dellemc/csi-powermax:v2.7.0


should be v2.8.0

rensyct · 2023-07-07T13:02:33Z

tests/config/driverconfig/powermax/v2.7.0/upgrade-path.yaml

@@ -1 +1 @@
-minUpgradePath: v2.6.0


Please remove test files related to v2.7.0

rensyct · 2023-07-07T13:03:25Z

tests/config/driverconfig/powermax/v2.8.0/upgrade-path.yaml

@@ -0,0 +1 @@
+minUpgradePath: v2.6.0


Should be v2.7.0

rensyct · 2023-07-07T13:03:48Z

operatorconfig/driverconfig/powermax/v2.8.0/controller.yaml

+            - name: socket-dir
+              mountPath: /var/run/csi
+        - name: driver
+          image: dellemc/csi-powermax:v2.7.0


should be v2.8.0

rensyct · 2023-07-07T13:04:07Z

operatorconfig/driverconfig/powermax/v2.8.0/node.yaml

+            capabilities:
+              add: ["SYS_ADMIN"]
+            allowPrivilegeEscalation: true
+          image: dellemc/csi-powermax:v2.7.0


Should be v2.8.0

rensyct · 2023-07-07T13:04:24Z

samples/storage_csm_powermax_v280.yaml

+      #   true: enable storage capacity tracking
+      #   false: disable storage capacity tracking
+      storageCapacity: true
+    # Config version for CSI PowerMax v2.7.0 driver


Should be v2.8.0

rensyct · 2023-07-07T13:04:40Z

samples/storage_csm_powermax_v280.yaml

+    forceUpdate: false
+    forceRemoveDriver: true
+    common:
+      # Image for CSI PowerMax driver v2.7.0


Should be v2.8.0

rensyct · 2023-07-07T13:04:58Z

tests/config/driverconfig/powermax/v2.8.0/controller.yaml

+            - name: socket-dir
+              mountPath: /var/run/csi
+        - name: driver
+          image: dellemc/csi-powermax:v2.7.0


Should be v2.8.0

rensyct · 2023-07-07T13:05:06Z

tests/config/driverconfig/powermax/v2.8.0/node.yaml

+            capabilities:
+              add: ["SYS_ADMIN"]
+            allowPrivilegeEscalation: true
+          image: dellemc/csi-powermax:v2.7.0


Should be v2.8.0

tssushma force-pushed the feature_sct branch from cc185f0 to 30f620c Compare June 26, 2023 10:12

shanmydell self-requested a review June 26, 2023 10:27

delldubey reviewed Jun 26, 2023

View reviewed changes

tssushma force-pushed the feature_sct branch from ebd815d to c949344 Compare June 28, 2023 04:36

delldubey previously approved these changes Jul 3, 2023

View reviewed changes

satyakonduri requested review from suryagupta4 and adarsh-dell July 4, 2023 10:32

tssushma dismissed delldubey’s stale review via 7751c88 July 6, 2023 08:40

tssushma force-pushed the feature_sct branch from df2db67 to ca5ba7c Compare July 7, 2023 08:40

rensyct suggested changes Jul 7, 2023

View reviewed changes

Updated Storage Capacity Tracking for powermax

eab553b

tssushma force-pushed the feature_sct branch from 6f08771 to eab553b Compare July 10, 2023 11:38

rensyct approved these changes Jul 10, 2023

View reviewed changes

shanmydell approved these changes Jul 10, 2023

View reviewed changes

shanmydell merged commit be426fe into main Jul 10, 2023
7 checks passed

shanmydell deleted the feature_sct branch July 10, 2023 12:05

ChristianAtDell added a commit that referenced this pull request Oct 15, 2024

Updated Storage Capacity Tracking for powermax (#281)

d9d958d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature StorageCapacityTracking for Powermax #281

Feature StorageCapacityTracking for Powermax #281

tssushma commented Jun 26, 2023 •

edited

Loading

delldubey Jun 26, 2023

tssushma Jun 30, 2023

delldubey left a comment

suryagupta4 commented Jul 4, 2023 •

edited

Loading

rensyct commented Jul 6, 2023

tssushma commented Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

rensyct Jul 7, 2023

		@@ -1 +1 @@
		minUpgradePath: v2.6.0

Feature StorageCapacityTracking for Powermax #281

Feature StorageCapacityTracking for Powermax #281

Conversation

tssushma commented Jun 26, 2023 • edited Loading

Description

GitHub Issues

Checklist:

How Has This Been Tested?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

delldubey left a comment

Choose a reason for hiding this comment

suryagupta4 commented Jul 4, 2023 • edited Loading

rensyct commented Jul 6, 2023

tssushma commented Jul 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tssushma commented Jun 26, 2023 •

edited

Loading

suryagupta4 commented Jul 4, 2023 •

edited

Loading