Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/resiliency module #246

Merged
merged 53 commits into from
May 23, 2023
Merged

Feature/resiliency module #246

merged 53 commits into from
May 23, 2023

Conversation

adarsh-dell
Copy link
Contributor

Description

Added E2E test for resiliency module and extending PowerFlex 2.7.0 sample file for supporting resiliency module along with UT coverage for resiliency.go file

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#739

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran E2E test for PowerStore, PowerScale and PowerFlex
  • Ran make unit-test and make driver-unit-test
  • Ran cert-csi after installing the PowerStore 2.7.0 driver, with and without enabling resiliency module.
  • Tested resiliency module for PowerFlex driver.

adarsh-dell and others added 30 commits March 21, 2023 16:44
@adarsh-dell
Supporting resiliency module
8704198
@adarsh-dell
Adding Driver & module combinations supported by CSM-operator
39e5763
@suryagupta4
Changes to operatorconfig
863de6d
@adarsh-dell
adding role to the controller & node pods
9dd0e43
@adarsh-dell
Enhancing logs
cf8c89e
@suryagupta4
modifying file read path
6763dfd
@adarsh-dell
Adding few more samples for powerscale and powerflex
855179d
@suryagupta4
added volumemount paths & privileged capabilities
8c04ed2
@adarsh-dell
version v1.7.0
52ad7a1
@adarsh-dell
Extracting driverType for picking right file
bdf864d
@adarsh-dell
Code cleanup
f666ae7
@adarsh-dell
UT first step
e7c2d18
@adarsh-dell
Resiliency module will be supported from v1.6.0 onwards for driver if…
b066763 
… installed by csm-operator
@suryagupta4
changed driver config version to v2.7.0 & resiliency to v1.6.0
ff77825
@suryagupta4
updated driver config params & min upgrade path for driver v2.7.0 config
230099e
@suryagupta4
Updated RBAC clusterrole fix (#211)
b0521a8
@sakshi-garg1
Resiliency-unit-test (#212)
e3eb6d0 
* Resiliency-unit-test

* Resiliency-unit-test

* Resiliency-unit-test
@adarsh-dell
Merge branch 'main' of https://github.com/dell/csm-operator into feat…
bffe26c 
…ure/resiliency_module
@adarsh-dell
Removing unnecessary extra lines
eb991c0
@adarsh-dell
Logic to handle isilon as well as powerscale
ab8e8e8
@adarsh-dell
Multi component for resiliency module (#218)
3081ac9 
* multi components for resiliency module
@adarsh-dell
Merging main branch
632275c
@adarsh-dell
Resiliency module support for PowerScale driver (#219)
2a9f512 
* Resiliency support for PowerScale

* Code cleanup

* yaml fix

* Permission for bidirectional mount

* Code cleanup
@suryagupta4
Updated kubelet config dir (#221)
5b2a44f
@sakshi-garg1
ModuleConfig Changes for Resiliency support for PowerFlex driver (#222)
802f32e 
* feature/Resiliency_module_support_powerflex

* feature/Resiliency_module_support_powerflex
@adarsh-dell
Merge branch 'main' of https://github.com/dell/csm-operator into feat…
860eee6 
…ure/resiliency_module
@adarsh-dell @jooseppi-luna
Code cleanup (#226)
a4f33b2 
* Remove VGS from PFlex config files (#220)

* removed or commented out vg-snap

* uncomment snapshotter

* remove vgs from csv file

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Code cleanup

* Merging main branch changes

* Code optimization

---------

Co-authored-by: Jooseppi Luna <[email protected]>
@adarsh-dell
Resolving review comment
0f76be6
@adarsh-dell
Removed setting unnecessary ENV var with default value
92a5981
@adarsh-dell
Merge branch 'main' into feature/resiliency_module
7284d4e
@adarsh-dell
Copy link
Contributor Author

Closing it for a while until I fix all checks.

@adarsh-dell adarsh-dell reopened this May 19, 2023
JacobGros
JacobGros reviewed May 22, 2023
View reviewed changes
tests/e2e/testfiles/values.yaml Outdated
customTest:
name: HelloWorld
run:
- "echo Hello && echo World"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we run cert-csi/resiliency e2e to make sure driver+resiliency is working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have ran it.

Copy link
Contributor

@JacobGros JacobGros May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking if we can run that for customTest in the e2e test

rensyct
rensyct previously approved these changes May 22, 2023
View reviewed changes
@adarsh-dell adarsh-dell merged commit 85c663f into main May 23, 2023
@rensyct rensyct deleted the feature/resiliency_module branch July 17, 2023 12:14
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell @suryagupta4
@sakshi-garg1 @jooseppi-luna @rishabhatdell
Feature/resiliency module (#246)
e56baa0 
* Supporting resiliency module

* Adding Driver & module combinations supported by CSM-operator

* Changes to operatorconfig

* adding role to the controller & node pods

* Enhancing logs

* modifying file read path

* Adding few more samples for powerscale and powerflex

* added volumemount paths & privileged capabilities

* version v1.7.0

* Extracting driverType for picking right file

* Code cleanup

* UT first step

* Resiliency module will be supported from v1.6.0 onwards for driver if installed by csm-operator

* changed driver config version to v2.7.0 & resiliency to v1.6.0

* updated driver config params & min upgrade path for driver v2.7.0 config

* Updated RBAC clusterrole fix (#211)

* Resiliency-unit-test (#212)

* Resiliency-unit-test

* Resiliency-unit-test

* Resiliency-unit-test

* Removing unnecessary extra lines

* Logic to handle isilon as well as powerscale

* Multi component for resiliency module (#218)

* multi components for resiliency module

* Resiliency module support for PowerScale driver (#219)

* Resiliency support for PowerScale

* Code cleanup

* yaml fix

* Permission for bidirectional mount

* Code cleanup

* Updated kubelet config dir (#221)

* ModuleConfig Changes for Resiliency support for PowerFlex driver (#222)

* feature/Resiliency_module_support_powerflex

* feature/Resiliency_module_support_powerflex

* Code cleanup (#226)

* Remove VGS from PFlex config files (#220)

* removed or commented out vg-snap

* uncomment snapshotter

* remove vgs from csv file

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Code cleanup

* Merging main branch changes

* Code optimization

---------

Co-authored-by: Jooseppi Luna <[email protected]>

* Resolving review comment

* Removed setting unnecessary ENV var with default value

* Podmon container reordering (#230)

* Resiliency E2E Changes (#234)

* resiliency e2e changes for powerstore

* ResiliencySideCarName spelling correction

* updated podmon sidecar check

* added e2e tests for powerflex resiliency

* updated yamls

* E2E test for powerscale driver with resiliency module

* update for custom test format & driver image version

* fixed indentation

* module set to true in storage_csm_powerscale_resiliency.yaml

* renaming variable

* Update storage_csm_powerflex.yaml

* updated driver image to latest for e2e test files

---------

Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: Kumar Yadav <[email protected]>

* Resiliency-unit-test-Updated (#240)

* fixing typo in e2e values.yaml

* Extending sample file for supporting resiliency module (#239)

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* adding replication module

* Removing UT for 2.6.0 PowerStore Driver

* UT coverage from 70% to 90+%

* Addressing review comment

* Addressing review comment

* updated driver image to nightly in e2e test files

* Updated custom tests in e2e

---------

Co-authored-by: suryagupta4 <[email protected]>
Co-authored-by: Surya Prakash Gupta <[email protected]>
Co-authored-by: sakshi-garg1 <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 left review comments

@JacobGros JacobGros JacobGros approved these changes

@rensyct rensyct rensyct approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2

@mjsdell mjsdell Awaiting requested review from mjsdell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@atye atye Awaiting requested review from atye

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adarsh-dell @JacobGros @rensyct @suryagupta4 @sakshi-garg1 @rishabhatdell