Skip to content

Commit

Permalink
fix yaml linting issues
Browse files Browse the repository at this point in the history
- using yamllint tool
  • Loading branch information
lukeatdell committed Aug 14, 2024
1 parent af95978 commit a975473
Show file tree
Hide file tree
Showing 584 changed files with 40,437 additions and 45,674 deletions.
3 changes: 1 addition & 2 deletions .github/containerscan/allowedlist.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
general:
vulnerabilities:
# list of CVEs that are currently unfixed

# list of CVEs that are currently unfixed
bestPracticeViolations:
# list of best practies violatied that needs a fix
- CIS-DI-0009
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,12 @@ jobs:
uses: actions/checkout@v4
- name: Build Docker Images
run: |
chmod +x ./scripts/build-ubi-micro.sh
make build-base-image
make -o gen-semver
podman build -t docker.io/csm-operator -f ./Dockerfile --build-arg GOIMAGE=golang:latest --build-arg BASEIMAGE="localhost/csm-operator-ubimicro"
podman save docker.io/library/csm-operator -o /tmp/csm-operator.tar
docker load -i /tmp/csm-operator.tar
chmod +x ./scripts/build-ubi-micro.sh
make build-base-image
make -o gen-semver
podman build -t docker.io/csm-operator -f ./Dockerfile --build-arg GOIMAGE=golang:latest --build-arg BASEIMAGE="localhost/csm-operator-ubimicro"
podman save docker.io/library/csm-operator -o /tmp/csm-operator.tar
docker load -i /tmp/csm-operator.tar
- name: Scan controller Image
uses: Azure/container-scan@v0
env:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
name: linters

on:
push:
branches: [main]
pull_request:
branches: ["**"]

permissions:
contents: read

jobs:
golangci-lint:
name: golangci-lint
Expand Down
3 changes: 0 additions & 3 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,17 @@ run:
tests: true
skip-dirs-use-default: true
modules-download-mode: readonly

issues:
max-issues-per-linter: 0
max-same-issues: 0
new: false
exclude:
- "parameter 'clusterConfigData' seems to be unused, consider removing or renaming it as _"

output:
print-linter-name: true
sort-results: true
uniq-by-line: false
print-issued-lines: true

linters:
disable-all: true
fast: false
Expand Down
2 changes: 0 additions & 2 deletions .yamllint.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
---
yaml-files:
- "*.yaml"
- "*.yml"
- ".yamllint"

rules:
braces: enable
brackets: enable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ metadata:
name: dell-csm-operator-controller-manager-metrics-service
spec:
ports:
- name: https
port: 8443
protocol: TCP
targetPort: https
- name: https
port: 8443
protocol: TCP
targetPort: https
selector:
control-plane: controller-manager
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,34 @@ metadata:
creationTimestamp: null
name: dell-csm-operator-leader-election-role
rules:
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- list
- watch
- create
- update
- patch
- delete
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- get
- list
- watch
- create
- update
- patch
- delete
- apiGroups:
- ""
resources:
- events
verbs:
- create
- patch
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- list
- watch
- create
- update
- patch
- delete
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- get
- list
- watch
- create
- update
- patch
- delete
- apiGroups:
- ""
resources:
- events
verbs:
- create
- patch
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ roleRef:
kind: Role
name: dell-csm-operator-leader-election-role
subjects:
- kind: ServiceAccount
name: default
namespace: default
- kind: ServiceAccount
name: default
namespace: default
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
creationTimestamp: null
name: dell-csm-operator-metrics-reader
rules:
- nonResourceURLs:
- /metrics
verbs:
- get
- nonResourceURLs:
- /metrics
verbs:
- get
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ metadata:
creationTimestamp: null
name: dell-csm-operator-proxy-role
rules:
- apiGroups:
- authentication.k8s.io
resources:
- tokenreviews
verbs:
- create
- apiGroups:
- authorization.k8s.io
resources:
- subjectaccessreviews
verbs:
- create
- apiGroups:
- authentication.k8s.io
resources:
- tokenreviews
verbs:
- create
- apiGroups:
- authorization.k8s.io
resources:
- subjectaccessreviews
verbs:
- create
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ roleRef:
kind: ClusterRole
name: dell-csm-operator-proxy-role
subjects:
- kind: ServiceAccount
name: default
namespace: default
- kind: ServiceAccount
name: default
namespace: default
Loading

0 comments on commit a975473

Please sign in to comment.