Addressing review comment

dell · May 22, 2023 · 3a08d0f · 3a08d0f
1 parent c4d5e63
commit 3a08d0f
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 24 deletions.
diff --git a/samples/storage_csm_powerflex_v270.yaml b/samples/storage_csm_powerflex_v270.yaml
@@ -323,13 +323,14 @@ spec:
       components:
         - name: podmon-controller
           args:
-            - "--csisock=unix:/var/run/csi/csi.sock"
             - "--labelvalue=csi-vxflexos"
-            - "--mode=controller"
             - "--skipArrayConnectionValidation=false"
-            - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
             - "--ignoreVolumelessPods=false"
+            # Below 3 args should not be modified.
+            - "--csisock=unix:/var/run/csi/csi.sock"
+            - "--mode=controller"
+            - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
         - name: podmon-node
           envs:
             # podmonAPIPort: Defines the port to be used within the kubernetes cluster
@@ -338,10 +339,11 @@ spec:
             - name: "X_CSI_PODMON_API_PORT"
               value: "8083"
           args:
-            - "--csisock=unix:/var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock"
             - "--labelvalue=csi-vxflexos"
-            - "--mode=node"
             - "--leaderelection=false"
-            - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
             - "--ignoreVolumelessPods=false"
+            # Below 3 args should not be modified.
+            - "--csisock=unix:/var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock"
+            - "--mode=node"
+            - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
diff --git a/samples/storage_csm_powerscale_v270.yaml b/samples/storage_csm_powerscale_v270.yaml
@@ -444,15 +444,16 @@ spec:
       components:
         - name: podmon-controller
           args:
-            - "--csisock=unix:/var/run/csi/csi.sock"
             - "--labelvalue=csi-isilon"
             - "--arrayConnectivityPollRate=60"
-            - "--driverPath=csi-isilon.dellemc.com"
-            - "--mode=controller"
             - "--skipArrayConnectionValidation=false"
-            - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
             - "--ignoreVolumelessPods=false"
+            # Below 4 args should not be modified.
+            - "--csisock=unix:/var/run/csi/csi.sock"
+            - "--mode=controller"
+            - "--driverPath=csi-isilon.dellemc.com"
+            - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml"
         - name: podmon-node
           envs:
             # podmonAPIPort: Defines the port to be used within the kubernetes cluster
@@ -461,12 +462,13 @@ spec:
             - name: "X_CSI_PODMON_API_PORT"
               value: "8083"
           args:
-            - "--csisock=unix:/var/lib/kubelet/plugins/csi-isilon/csi_sock"
             - "--labelvalue=csi-isilon"
             - "--arrayConnectivityPollRate=60"
-            - "--driverPath=csi-isilon.dellemc.com"
-            - "--mode=node"
             - "--leaderelection=false"
-            - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
-            - "--ignoreVolumelessPods=false"
+            - "--ignoreVolumelessPods=false"
+            # Below 4 args should not be modified.
+            - "--csisock=unix:/var/lib/kubelet/plugins/csi-isilon/csi_sock"
+            - "--mode=node"
+            - "--driverPath=csi-isilon.dellemc.com"
+            - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml"
diff --git a/samples/storage_csm_powerstore_v270.yaml b/samples/storage_csm_powerstore_v270.yaml
@@ -157,15 +157,16 @@ spec:
       components:
         - name: podmon-controller
           args:
-            - "--csisock=unix:/var/run/csi/csi.sock"
             - "--labelvalue=csi-powerstore"
             - "--arrayConnectivityPollRate=60"
-            - "--driverPath=csi-powerstore.dellemc.com"
-            - "--mode=controller"
             - "--skipArrayConnectionValidation=false"
-            - "--driver-config-params=/powerstore-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
             - "--ignoreVolumelessPods=false"
+            # Below 4 args should not be modified.
+            - "--csisock=unix:/var/run/csi/csi.sock"
+            - "--mode=controller"
+            - "--driver-config-params=/powerstore-config-params/driver-config-params.yaml"
+            - "--driverPath=csi-powerstore.dellemc.com"
         - name: podmon-node
           envs:
             # podmonAPIPort: Defines the port to be used within the kubernetes cluster
@@ -174,12 +175,13 @@ spec:
             - name: "X_CSI_PODMON_API_PORT"
               value: "8083"
           args:
-            - "--csisock=unix:/var/lib/kubelet/plugins/csi-powerstore.dellemc.com/csi_sock"
             - "--labelvalue=csi-powerstore"
             - "--arrayConnectivityPollRate=60"
-            - "--driverPath=csi-powerstore.dellemc.com"
-            - "--mode=node"
             - "--leaderelection=false"
-            - "--driver-config-params=/powerstore-config-params/driver-config-params.yaml"
             - "--driverPodLabelValue=dell-storage"
-            - "--ignoreVolumelessPods=false"
+            - "--ignoreVolumelessPods=false"
+            # Below 4 args should not be modified.
+            - "--csisock=unix:/var/lib/kubelet/plugins/csi-powerstore.dellemc.com/csi_sock"
+            - "--mode=node"
+            - "--driver-config-params=/powerstore-config-params/driver-config-params.yaml"
+            - "--driverPath=csi-powerstore.dellemc.com"