Use generic zone labels #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdawe
force-pushed
the
usr/falfaroc/generic-zone-labels
branch
from
905b90f to
0994807
Compare
tdawe
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004 and
donatwork
as code owners
|
can you please update the sample secret with the zone key "labelKey"? |
falfaroc
requested changes
Dec 2, 2024
There was a problem hiding this comment.
As @bpjain2004 stated, please update the multi-az secret sample.
Updated the sample secret with labelKey |
falfaroc
approved these changes
Dec 2, 2024
lukeatdell
approved these changes
Dec 2, 2024
falfaroc
pushed a commit
that referenced
this pull request
Dec 18, 2024
falfaroc
pushed a commit
that referenced
this pull request
Dec 18, 2024
falfaroc
added a commit
that referenced
this pull request
Dec 19, 2024
* Add availability zone secret and struct (#352) * add availability zone secret and struct * Add multi availability zone storage class (#353) * Add Multi-Available Zone Functionality (#354) * Add create volume processing for multi-az * Adjust multi-az secret processing * Rework secret processing * Iterate through all topologies for a zone * Test signing commit * Cleanup secret retrieval and backwards compatibility of storage classes * adapt to use new secret struct * Add multi-az unit tests * Fix golangci-lint issue * Cleanup code logs * Make zone take precendence during NodeGetInfo * Update unit tests credentials --------- Co-authored-by: Lau, Luke <[email protected]> * Unit tests for Node Topologies (#358) * Adding Unit tests * fixing formatting issues * Use generic zone labels (#360) * Add zone volume creation integration tests (#359) * Add zone volume creation integration tests * Fix golangci-lint issue * Create e2e zone tests * Adjust indentation of template yaml files * Adjust indentation of template yaml files * Update e2e file names * Format e2e files for golangci-lint * Update e2e test scenarios * Update pod templates * Address PR comments * Add README to e2e tests * Update sts templates * Added Integration tests for NodeGetInfo * fixing linting checks * Renaming function arguments * Add Snapshot and Clone Support for Multi-Available Zone (#365) * Add snapshot check and topology add during zone volume creation * Add topology checks for clones * Add zone snapshot and restore e2e test * Address failed PR checks * Update README * Added e2e tests for clones * Add snap and clone test (#371) * Address PR comments --------- Co-authored-by: Trevor Dawe <[email protected]> Co-authored-by: Bharath Sreekanth <[email protected]> * Driver Node should only ping arrays within the zone on which the pod is scheduled (#378) * configure driver node service to only ping arrays in the same zone as the service. Co-authored-by: Fernando Alfaro Campos <[email protected]> Co-authored-by: Trevor Dawe <[email protected]> * Fix rebase issues * Address PR comments * Address PR comments * Address PR comments --------- Co-authored-by: lukeatdell <[email protected]> Co-authored-by: Lau, Luke <[email protected]> Co-authored-by: Harshita Pandey <[email protected]> Co-authored-by: Trevor Dawe <[email protected]> Co-authored-by: Harshita Pandey <[email protected]> Co-authored-by: Bharath Sreekanth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow custom zone labels to be used for topology. Instead of requiring the zone label to be zone.csi-vxflexos.dellemc.com, the customer can now provide a custom label.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration