Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage for host, host group, port, por group, job #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

P-Cao
Copy link

@P-Cao P-Cao commented Jan 24, 2025

Description

Improve coverage

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

image

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.24812% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (237b0fe) to head (e1fd5da).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tests/unit/plugins/module_utils/mock_host_api.py 77.77% 1 Missing and 3 partials ⚠️
tests/unit/plugins/modules/test_host.py 99.01% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   54.69%   69.41%   +14.71%     
===========================================
  Files          31       43       +12     
  Lines        3863     5290     +1427     
  Branches      580      717      +137     
===========================================
+ Hits         2113     3672     +1559     
+ Misses       1548     1411      -137     
- Partials      202      207        +5     
Flag Coverage Δ
units 69.41% <99.24%> (+14.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@P-Cao P-Cao force-pushed the improve-cov-port-pg-host-hg-job branch 6 times, most recently from 7e0c63d to 9b21a25 Compare January 26, 2025 05:49
@P-Cao P-Cao force-pushed the improve-cov-port-pg-host-hg-job branch from 9b21a25 to e1fd5da Compare January 26, 2025 05:55
@P-Cao P-Cao marked this pull request as ready for review January 26, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants