SDT deployment role #64
Conversation
RayLiu7
requested review from
Bhavneet-Sharma,
Jennifer-John,
meenakshidembi691,
trisha-dell,
felixs88 and
sachin-apa
as code owners
|
Can one of the admins verify this patch? |
RayLiu7
force-pushed
the
sdt-deployment
branch
2 times, most recently
from
019e5f7
to
3a84872
Compare
|
run e2e |
RayLiu7
force-pushed
the
sdt-deployment
branch
4 times, most recently
from
4d9fc66
to
ce42839
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 91.95% 91.87% -0.09%
==========================================
Files 49 49
Lines 7311 7348 +37
Branches 919 902 -17
==========================================
+ Hits 6723 6751 +28
- Misses 309 316 +7
- Partials 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RayLiu7
force-pushed
the
sdt-deployment
branch
2 times, most recently
from
d27470b
to
724585d
Compare
RayLiu7
force-pushed
the
sdt-deployment
branch
from
724585d
to
7ac8d32
Compare
| @@ -0,0 +1,3 @@ | |||
| #powerflex sdt params | |||
| powerflex_sdt_ip_list: 10.x.x.1,10.x.x.2 | |||
| powerflex_sdt_role_list: storage_and_host,storage_and_host | |||
| @@ -0,0 +1,3 @@ | |||
| #powerflex sdt params | |||
| powerflex_sdt_ip_list: 10.x.y.1,10.x.y.2 | |||
| powerflex_sdt_role_list: storage_and_host,storage_and_host | |||
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| file_glob_name: sdt | |||
| i_am_sure: 1 | |||
There was a problem hiding this comment.
file_glob_name, i_am_sure if these vars are not user inputs, move this to vars/main.yml
lets follow role_name_ convention, if these are role inputs, and update the doc and arg spec accordingly.
| --- | ||
| file_glob_name: sdt | ||
| file_gpg_name: RPM-GPG-KEY-ScaleIO | ||
| powerflex_role_environment: |
There was a problem hiding this comment.
I don't see a usage of this var anywhere in the task. Can you please check if this is required.
| ansible.builtin.include_tasks: ../../powerflex_common/tasks/install_powerflex.yml | ||
|
|
||
| - name: Add certificate file for PowerFlex version 4.x | ||
| ansible.builtin.command: scli --add_certificate --certificate_file /opt/emc/scaleio/mdm/cfg/mgmt_ca.pem |
There was a problem hiding this comment.
Its good to move the commands to vars/main.yml and duynamically replace the values as required.
| when: powerflex_sdt_array_version != "3" | ||
| rescue: | ||
| - name: Generate login certificate using primary_mdm_ip | ||
| ansible.builtin.command: > |
There was a problem hiding this comment.
Its good to move the commands to vars/main.yml and duynamically replace the values as required.
| when: powerflex_sdt_array_version != "3" | ||
|
|
||
| - name: Login to MDM for PowerFlex version 4.x | ||
| ansible.builtin.command: scli --login --p12_path /opt/emc/scaleio/mdm/cfg/cli_certificate.p12 --p12_password {{ password }} |
There was a problem hiding this comment.
Its good to move the commands to vars/main.yml and duynamically replace the values as required.
| when: powerflex_sdt_array_version != "3" | ||
|
|
||
| - name: Remove SDT | ||
| ansible.builtin.command: |
There was a problem hiding this comment.
Its good to move the commands to vars/main.yml and duynamically replace the values as required.
| powerflex_sdt_primary_mdm_ip: "{{ hostvars[groups['mdm'][0]]['ansible_host'] }}" | ||
|
|
||
| - name: Add certificate file for PowerFlex version 4.x | ||
| ansible.builtin.command: scli --add_certificate --certificate_file /opt/emc/scaleio/mdm/cfg/mgmt_ca.pem |
There was a problem hiding this comment.
Its good to move the commands to vars/main.yml and duynamically replace the values as required.
| state: "absent" | ||
| with_items: | ||
| - EMC-ScaleIO-sdt | ||
| when: ansible_distribution in ("RedHat", "CentOS", "SLES") |
There was a problem hiding this comment.
How are we ensuring ansible_distribution value is populated ?
Description
Implement SDT deployment
sdt_installation
sdt_uninstallation
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration