add lxml to requirements.txt #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Añadiré el requerimiento de lxml. El refactor está bien, pero como la app seguirá el desarrollo por otro camino veo como integrarlo más adelante. Gracias @adagio |
|
Ya veo, yo solo quise hacer pull request del primer commit, el de nombre “add lxml to requirements.txt” El refactor lo hice para mi forma de trabajo personal e ir siguiendo los avances tuyos Gracias Daniel, justo en este momento te estoy oyendo en el podcast de Mosqueteros 😃 |
|
Gracias a ti, también es bueno practicar con las PR en vivo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lxml es necesario para ejecutar el script