Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download file problem fix! #273

Closed
wants to merge 2 commits into from
Closed

Download file problem fix! #273

wants to merge 2 commits into from

Conversation

bilaldhudi
Copy link

Download file problem fix!

@ocram
Copy link
Contributor

ocram commented Oct 15, 2020

Thank you!

It’s not clear what problem exactly you’re trying to solve. Further, onDownloadStart (replacing the call to onDownloadRequested) is certainly not the correct place for this.

However, two (potential) issues have been extracted from your pull request to issues #277 and #278. Thanks again!

@ocram ocram closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilaldhudi @ocram