Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing/disallowing subdomains #260

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mmiszczyk
Copy link

Right now, AdvancedWebView will always trust not only a specified hostname but also all of its subdomains. It might be a better idea to make it configurable. In this patch, I've added the setAllowSubdomains() method which decides whether we want the subdomains (by passing true) or the exact match on the hostname (by passing false). The default behavior is still to allow them for compatibility reasons (we don't want to break other people's code).

@mmiszczyk mmiszczyk requested a review from ocram January 14, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant