Create directory for mount target provided in configuration file #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvrada
force-pushed
the
fix_mount
branch
2 times, most recently
from
201d3f2 to
e1ee3c1
Compare
vtikoo
reviewed
Jun 30, 2022
kernel/enter.c
Outdated
|
|
||
| if (errornum == -ENOENT) | ||
| // target do not exist, create directory | ||
| ECHECK(myst_syscall_mkdir(locals->suffix.buf, 0777)); |
There was a problem hiding this comment.
Isn't locals->suffix a path relative to where the filesystem to which target belongs is mounted?
There was a problem hiding this comment.
For the case where target belongs to rootfs it doesn't make a difference. But if the target(say /mnt/target) is on a filesystem mounted at some path(say /mnt). Then myst_mount_resolve will return just /target as the suffix.
Why don't you directly use normalized_target here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using config.json to specify mount information, create target folders if they do not exist.