-
Notifications
You must be signed in to change notification settings - Fork 53
feat(health checks): implement new kubernetes 1.2 health check features #600
Conversation
Current coverage is
|
Can you drop a |
Yeah, I have #570 but realised just now these are not ENV Vars :P I need to turn Health Checks into a section of the config instead of general configuration |
Created deis/workflow#134 to track documentation needs |
Wrote deis/workflow#135 for the documentation |
987b1bf
to
6e9b330
Compare
Added the following new functionalities * HEALTHCHECK_PERIOD_SECONDS - How often (in seconds) to perform the probe * HEALTHCHECK_SUCCESS_THRESHOLD - How many probe runs need to be done after failure to consider it a success again * HEALTHCHECK_FAILURE_THRESHOLD - How many times a probe should fail before considered being down These defaults are all copied from kubernetes but may have to be adjusted due to our high default timeout, or we bring the default timeout down Closes deis#251
This lgtm. In case it helps anyone else, I asked @helgi for some additional information on what's going on here, so adding that info here in case it helps anyone else: this PR adds the above env variables that are settable via |
feat(charts): Add support to add annotations for router during install
Added the following new functionalities
HEALTHCHECK_PERIOD_SECONDS
- How often (in seconds) to perform the probeHEALTHCHECK_SUCCESS_THRESHOLD
- How many probe runs need to be done after failure to consider it a success againHEALTHCHECK_FAILURE_THRESHOLD
- How many times a probe should fail before considered being downThese defaults are all copied from kubernetes but may have to be adjusted due to our high default timeout, or we bring the default timeout down
Closes #251
Depends on #591 being merged first