Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

feat(health checks): implement new kubernetes 1.2 health check features #600

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

helgi
Copy link
Contributor

@helgi helgi commented Apr 4, 2016

Added the following new functionalities

  • HEALTHCHECK_PERIOD_SECONDS - How often (in seconds) to perform the probe
  • HEALTHCHECK_SUCCESS_THRESHOLD - How many probe runs need to be done after failure to consider it a success again
  • HEALTHCHECK_FAILURE_THRESHOLD - How many times a probe should fail before considered being down

These defaults are all copied from kubernetes but may have to be adjusted due to our high default timeout, or we bring the default timeout down

Closes #251
Depends on #591 being merged first

@helgi helgi self-assigned this Apr 4, 2016
@helgi helgi added this to the v2.0-rc1 milestone Apr 4, 2016
@codecov-io
Copy link

Current coverage is 83.68%

Merging #600 into master will increase coverage by +0.29% as of 16c8511

@@            master    #600   diff @@
======================================
  Files           36      36       
  Stmts         2427    2433     +6
  Branches       351     351       
  Methods          0       0       
======================================
+ Hit           2024    2036    +12
+ Partial        116     114     -2
+ Missed         287     283     -4

Review entire Coverage Diff as of 16c8511

Powered by Codecov. Updated on successful CI builds.

@slack
Copy link
Member

slack commented Apr 4, 2016

Can you drop a deis/workflow issue to track adding these to the docs?

@helgi
Copy link
Contributor Author

helgi commented Apr 4, 2016

Yeah, I have #570 but realised just now these are not ENV Vars :P I need to turn Health Checks into a section of the config instead of general configuration

@helgi
Copy link
Contributor Author

helgi commented Apr 4, 2016

Created deis/workflow#134 to track documentation needs

@helgi
Copy link
Contributor Author

helgi commented Apr 5, 2016

Wrote deis/workflow#135 for the documentation

@helgi helgi removed the needs docs label Apr 5, 2016
@helgi helgi force-pushed the new_health branch 3 times, most recently from 987b1bf to 6e9b330 Compare April 6, 2016 17:31
Added the following new functionalities

* HEALTHCHECK_PERIOD_SECONDS - How often (in seconds) to perform the probe
* HEALTHCHECK_SUCCESS_THRESHOLD - How many probe runs need to be done after failure to consider it a success again
* HEALTHCHECK_FAILURE_THRESHOLD - How many times a probe should fail before considered being down

These defaults are all copied from kubernetes but may have to be adjusted due to our high default timeout, or we bring the default timeout down

Closes deis#251
@arschles arschles added the LGTM1 label Apr 6, 2016
@arschles
Copy link
Member

arschles commented Apr 6, 2016

This lgtm.

In case it helps anyone else, I asked @helgi for some additional information on what's going on here, so adding that info here in case it helps anyone else:

this PR adds the above env variables that are settable via config:set, which tell the controller how to configure app pods w.r.t. health check information. There is also a plan in #603 to move these config values to a top level config element, similar to what we do for tags.

@helgi helgi merged commit a3ddea7 into deis:master Apr 7, 2016
@helgi helgi deleted the new_health branch April 7, 2016 16:55
duanhongyi pushed a commit to duanhongyi/workflow that referenced this pull request Dec 4, 2018
feat(charts): Add support to add annotations for router during install
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants