This repository was archived by the owner on May 6, 2020. It is now read-only.
feat(health checks): implement new kubernetes 1.2 health check features #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following new functionalities
HEALTHCHECK_PERIOD_SECONDS
- How often (in seconds) to perform the probeHEALTHCHECK_SUCCESS_THRESHOLD
- How many probe runs need to be done after failure to consider it a success againHEALTHCHECK_FAILURE_THRESHOLD
- How many times a probe should fail before considered being downThese defaults are all copied from kubernetes but may have to be adjusted due to our high default timeout, or we bring the default timeout down
Closes #251
Depends on #591 being merged first