PowerTarget device #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asreek6654
reviewed
Jan 23, 2025
| num_nodes: int | ||
| terminal: NDArray | ||
| target_power: NDArray = field(converter=make_dynamic) | ||
| norm_order: int = field(default=2) |
There was a problem hiding this comment.
We're allowing the user to set the norm order to determine the penalty function, but in the ADMM proximal update we are hard-coding the update for the L2 norm squared right? That might be an issue if someone expects that they can change this to an L1 norm or something for example
There was a problem hiding this comment.
Good catch. I now restrict the norm to be either L1 or L2 and added different prox updates for each one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asreek6654 Take a quick peek if you can.