Cover Kaiserfile class with tests #39
Conversation
davidsiaw
force-pushed
the
test-kaiserfile
branch
2 times, most recently
from
bf26b5a
to
3f97f1e
Compare
davidsiaw
force-pushed
the
test-kaiserfile
branch
from
cd1c4c9
to
28e0ae2
Compare
|
@Resonious please review this |
spec/spec_helper.rb
Outdated
| begin | ||
| Aruba::RSpec.teardown | ||
| rescue StandardError => e | ||
| puts e | ||
| end |
There was a problem hiding this comment.
What's the begin/rescue for? Seems to work for me without. And I imagine if this were to error, the puts e might be a bit confusing if you don't know what it's coming from.
spec/kaiserfile_spec.rb
Outdated
| expect(kaiserfile.database[:image]).to eq 'somedb:version' | ||
| expect(kaiserfile.database[:data_dir]).to eq '/var/lib/dbdb' | ||
| expect(kaiserfile.database[:port]).to eq 1414 |
There was a problem hiding this comment.
Do you think this spec should only test kaiserfile.database[:commands]? The other attributes are already tested for in the above spec. Right now if any of those other attributes don't work, it'll make every spec fail for the same reason, even if :commands still works.
(Same applies to the below specs)
There was a problem hiding this comment.
I guess you are right I'll try and slim this down
|
@Resonious sorry it took so long but could you have a look at this again? I removed the less useful expects from the tests. |
Ref #24
Ref #25
This PR adds tests for the Kaiserfile class, as an ongoing effort to start increasing Kaiser's test coverage. With this we will be able to modify the Kaiserfile syntax with more confidence, and it will double as documentation.
How to test
rspecand see Kaiserfile tests