This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
use updated dockerdns #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sikachu can you help us review this PR, please? |
sikachu
reviewed
Jun 10, 2024
| phensley/docker-dns | ||
| -e DOCKER_HOST='unix:///var/run/docker.sock' | ||
| -v /var/run/docker.sock:/var/run/docker.sock:ro | ||
| davidsiaw/dockerdns |
There was a problem hiding this comment.
Should we fork this into degica account instead?
There was a problem hiding this comment.
we can. i can do that in another pr. i actually have a nice build system and everything on that now
sikachu
approved these changes
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream dockerdns was using a very old version of the docker-py libraries that could not handle some of the weirder shit docker does. This fixes that.
To test this you need to update to the latest docker (26 and above)
just kaiser up any project.