Increase max body size to handle POST requests larger than 10MB #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarsh95
approved these changes
Nov 6, 2024
|
@Daivasmara I intentionally didn't add the Slack link since this is a public repo 😄 (It's safe though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A payload in some POST requests could be higher than 10MB, especially when users upload images or files.
Ideally, I want to increase the value to 50MB, but at the same time, I don't want to increase the memory allocation for the Nginx container to minimize the impact. So, I feel 30MB is the maximum acceptable value for 128MB memory allocation.