Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python #813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update python #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions dockerfiles/run-pack/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
FROM alpine:3.5

ENV GOPATH /.go
ENV GOBIN $GOPATH/bin
ENV PATH=$GOBIN:$PATH
FROM alpine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the version to prevent it from being updated to 4.0 without us noticing?

Suggested change
FROM alpine
FROM alpine:3.20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pinned it once but i think its better to just keep it up to date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep it up to date explicitly by creating PR. If we have many places that update versions automatically, it's hard to identify which new library version introduce a problem. (We will need to visit every release page to check the latest release or compare installed versions using old and new environments.)

ADD . /.go/src/app

RUN apk add --no-cache go curl git gcc libc-dev glide \
&& cd $GOPATH/src/app \
&& mkdir -p $GOBIN \
RUN apk add --no-cache go curl git gcc libc-dev \
&& cd /.go/src/app \
&& mkdir /barcelona \
&& glide install \
&& go build -o /barcelona/barcelona-run --ldflags '-linkmode external -extldflags "-static"' \
&& rm -rf /.go \
&& apk del --purge go curl git gcc libc-dev
Expand Down
40 changes: 0 additions & 40 deletions dockerfiles/run-pack/glide.lock
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions dockerfiles/run-pack/glide.yaml
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions dockerfiles/run-pack/watch_interactive_session_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package main

import (
"fmt"
"log"
"testing"

ps "github.com/mitchellh/go-ps"
Expand All @@ -24,6 +26,7 @@ func (p *ProcessMock) Executable() string {
}

func TestOtherSessionRunning(t *testing.T) {
log.Println(fmt.Sprintf("Interactive session has not started for %d seconds", 123))
ps1 := []ps.Process{
&ProcessMock{pid: 1, ppid: 0},
&ProcessMock{pid: 10, ppid: 1},
Expand Down
2 changes: 1 addition & 1 deletion lib/barcelona/network/autoscaling_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def build_resources
end

j.Handler "index.lambda_handler"
j.Runtime "python3.7"
j.Runtime "python3.12"
j.Timeout "60"
j.Role get_attr("ASGDrainingFunctionRole", "Arn")
j.Environment do |j|
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/barcelona/network/network_stack_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
"ZipFile" => kind_of(String)
},
"Handler" => "index.lambda_handler",
"Runtime" => "python3.7",
"Runtime" => "python3.12",
"Timeout" => "60",
"Role" => {"Fn::GetAtt" => ["ASGDrainingFunctionRole", "Arn"]},
"Environment" => {
Expand Down
Loading