fix that endpoint names are global #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuuki77
commented
Mar 8, 2021
| endpoint.save! | ||
| expect_any_instance_of(CloudFormation::Executor).to receive(:delete) | ||
| endpoint.destroy! | ||
| end | ||
| end | ||
|
|
||
| describe "#validations" do |
There was a problem hiding this comment.
shoulda-matchers doesn't support scope with association.
so I wrote the code like this.
thoughtbot/shoulda-matchers#814
|
actually this is not going to work because endpoint name is used for load balancer name and it should be unique in region. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616
If you create an endpoint named A in district 1, you cant make an endpoint named A in district 2, even though there is no reason you shouldn't be able to.
How to test
I think looking at the test should be ok