Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update datadog plugin #573

Merged
merged 4 commits into from
Apr 17, 2020
Merged

update datadog plugin #573

merged 4 commits into from
Apr 17, 2020

Conversation

davidsiaw
Copy link
Contributor

@davidsiaw davidsiaw commented Apr 3, 2020 •
edited
Loading

Context

This PR fixes up the datadog agent to make it compatible with the latest version of its agent.

Fixes #571

How to test

You can create a free trial account with datadog to test this. They will provide you with an API key when you select the docker integration

  1. Start up a barcelona district, or if you already have a test one just use that
  2. Run bcn district put-plugin --apply -a api_key=<apikey> <districtname> datadog
  3. Go to aws to your district and apply the changeset that was created (see Update plugin for district does not update anything #572 )
  4. Apply the changeset
  5. Go to datadog after 5 mins and check that metrics of your containers are coming in

@davidsiaw davidsiaw marked this pull request as ready for review April 8, 2020 09:45
@degicat
Copy link

degicat commented Apr 8, 2020

@essa please review this

@degicat degicat requested a review from essa April 8, 2020 09:46
essa
essa approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@essa essa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry for very late reply

@davidsiaw
Copy link
Contributor Author

Thanks for the review!

@davidsiaw davidsiaw merged commit e2aac94 into master Apr 17, 2020
@davidsiaw davidsiaw deleted the datadog branch April 17, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@essa essa essa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix up datadog plugin for barcelona
3 participants
@davidsiaw @degicat @essa