Handle service CF stack failure #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olingern
reviewed
Jul 27, 2018
| @@ -40,6 +40,6 @@ def perform(heritage, without_before_deploy:, description: "") | |||
|
|
|||
| def other_deploy_in_progress?(heritage) | |||
| return false if heritage.version == 1 | |||
| heritage.services.map { |s| !s.deployment_finished?(nil) }.any? | |||
| heritage.services.map { |s| s.deployment_status(nil) == :in_progress }.any? | |||
|
This looks kind of straight forward, and looks like it would prevent deploying while another is in-progress. Is there anything else that needs to be done to merge? ( other than code clean up / rebase ) |
|
Looks like I just forgot to merge. I'll self-review again when I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.