Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint names are global #616

Open
davidsiaw opened this issue Sep 9, 2020 · 1 comment · Fixed by #660
Open

Endpoint names are global #616

davidsiaw opened this issue Sep 9, 2020 · 1 comment · Fixed by #660

Comments

@davidsiaw
Copy link
Contributor

davidsiaw commented Sep 9, 2020

If you create an endpoint named A in district 1, you cant make an endpoint named A in district 2, even though there is no reason you shouldn't be able to.

Possible fix

We should use the district parameter when creating an endpoint, and require that all operations on the endpoint require the district to be specified.

@davidsiaw
Copy link
Contributor Author

We will revert #660 because it introduces an unexpected change to the way barcelona behaves.

If you go

bcn endpoint create hello -d staging

Barcelona then creates an endpoint called staging-hello.

If in the past another district test has and endpoint called staging-hello, this PR causes barcelona to either fail or worse overwrite the endpoint name (we don't know what will happen)

This PR did not resolve the global endpoint name issue and caused the above new issue, so we are reverting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant