Merge pull request #796 from degica/ordered-ecs-service-build

Fix ECSService sometimes failing to create
degica · Sep 7, 2023 · e630f08 · e630f08
2 parents e229b1b + 9d2d730
commit e630f08
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/app/models/backend/ecs/v2/service_stack.rb b/app/models/backend/ecs/v2/service_stack.rb
@@ -2,8 +2,16 @@ module Backend::Ecs::V2
   class ServiceStack < CloudFormation::Stack
     class Builder < CloudFormation::Builder
       def build_resources
-        add_resource("AWS::ECS::Service", "ECSService") do |j|
-          j.Cluster district.name
+        deps = []
+        if use_alb?
+          deps = ['LBListenerRuleHTTP']
+
+          if listener&.endpoint&.https_listener_id&.present?
+            deps << 'LBListenerRuleHTTPS'
+          end
+        end
+
+        add_resource("AWS::ECS::Service", "ECSService", { depends_on: deps }) do |j|          j.Cluster district.name
           j.TaskDefinition options[:task_definition]
           j.DesiredCount options[:desired_count]
           if use_tcp_load_balancer?