Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase transaction #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benzenwen
Copy link
Contributor

Firebase's transaction provides for atomic data modification, useful for multi-user applications that edit data dynamically.

This pull requests implements a straight JavaScript translation :firebase/transaction, and a more Clojure-y variant :firebase/swap that accepts an :argv vector for passing in other values.

Please let me know if there are any suggested changes or administrative tasks that I can undertake that make your review easier.

Thank you for your consideration.

Added 2-arity wrapper-handler. Readme improvements.
@benzenwen
Copy link
Contributor Author

Rebased to a single commit as discussed.

With gratitude, B.

@deg
Copy link
Owner

deg commented Jun 28, 2019

I just read your comments and skimmed the code. I like this direction a lot; thanks for writing it!

My only problem is that I don't have time to test for at least the next week or two. For now, please continue using this privately, with my assurances that:

  • I expect that I will happily accept this code sometime soon
  • I don't plan to make any other changes to master before this code

If other folks are reading this exchange and also wants to use this, please upvote or comment.

@benzenwen
Copy link
Contributor Author

Thank you. 🙏 That timing is fine. Let me know if there are any changes you'd recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants