Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get fallback #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix get fallback #421

wants to merge 1 commit into from

Conversation

easonyq
Copy link

@easonyq easonyq commented Aug 4, 2014

This fix a problem when GET method comes to fallbackPjax.
Usually in GET method, we tend to use

{
    url: '/?a=1&b=2'
} 

rather than

{
    url: '/', 
    data: 'a=1&b=2'
}

But any parameters written in action attribute of <form> element with GET method will be ignored.
e.g.

<form action="/?a=1&b=2" method='GET'>

is equivalent to

<form action="/' method='GET'>

Thus we need to add these parameters using hidden input.

@mislav
Copy link
Collaborator

mislav commented Sep 15, 2014

Thanks. I'd like to see a failing test for this first that this commit fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants