Bump browserify-istanbul #289
Conversation
Old version disallowed most es6 syntax.
|
By analyzing the blame information on this pull request, we identified @vvo, @defunctzombie and @bevacqua to be potential reviewers |
|
I would be awesome to get this merged in. We are using my fork of this for testing on choo but would love to not use a direct link to a github repo for testing! Happy to make any changes necessary |
|
Not sure if we would have to major bump after this? |
|
Possibly? It looks like all the changes since 0.1.5 are upping other dependencies. Istanbul is at 0.4.2 instead of 0.2.8 -- that seems to be the main difference (other than options you can pass in to the created instance). |
|
Having to bump major for istanbul maybe seen as weird but I am down for it if needed. cc @rase- you did the original istanbul integration, any thoughts? |
| @@ -7,7 +7,7 @@ | |||
| "JSON2": "0.1.0", | |||
| "batch": "0.5.0", | |||
| "browserify": "13.0.0", | |||
| "browserify-istanbul": "0.1.5", | |||
| "browserify-istanbul": "^2.0.0", | |||
There was a problem hiding this comment.
this doesn't follow the pattern of the other dependencies...be mindful to be consistent
Old version disallowed most ES6 syntax, namely template strings.