Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of virtual threads #594

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

ekharkunov
Copy link
Contributor

Reconfigure executor to support virtual threads. Set virtual thread enable flag to false by default.

Fixes #584

@ekharkunov ekharkunov force-pushed the issue-584-virtual-threads branch from 789b1ba to aa4b202 Compare January 8, 2025 16:46
@@ -47,6 +47,9 @@ spring:
# Don't check for templates on startup
mustache:
check-template-location: false
threads:
virtual:
enabled: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set default to false to control on deployment and not to break previous behavior (in case of any problem)

@ekharkunov ekharkunov requested a review from britzl January 8, 2025 16:47
@ekharkunov ekharkunov marked this pull request as ready for review January 8, 2025 16:47
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with virtual threads in java, but the changes look ok

@ekharkunov ekharkunov merged commit da50ad9 into dev Jan 9, 2025
@ekharkunov ekharkunov deleted the issue-584-virtual-threads branch January 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable virtual threads
2 participants