Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify questions in basic #162

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Clarify questions in basic #162

merged 1 commit into from
Jun 12, 2024

Conversation

rishsriv
Copy link
Member

Made 2 changes:

In the question Who were the top 3 sales representatives by total revenue in the past 3 months, inclusive of today's date? Return their first name, last name, total number of sales and total revenue., revenue could have conceivably referred to both the sum of sale_pricein the sales table, and the sum of payment_amount in the payments_received table. Made this more explicit in the question

In the question Return the distinct list of merchant IDs that have received money from a transaction. Include all transaction types in the results you return. - the person reading thing could conceivably think that they must include the transaction_type column in the results as well. So made the question clearer.

Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the revenue definition, thanks for the clarifications!

@rishsriv rishsriv merged commit 7ce1c63 into main Jun 12, 2024
2 checks passed
@rishsriv rishsriv deleted the rishabh/clarify-questions branch June 12, 2024 06:42
@wendy-aw
Copy link
Contributor

Thanks for this! Lemme change the questions too in the dialect files

wendy-aw added a commit that referenced this pull request Jun 12, 2024
rishsriv pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants