New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval script fixes #138

Merged

rishsriv merged 1 commit into main from jp/gcs

May 17, 2024

Collaborator

wongjingping commented May 17, 2024

Updated gcs_eval_checkpoints.py to save tokenizer if it is missing from checkpoint directory
Fixed wrong directory when moving to eval folder. Previously it would save model weights into checkpoint-xxx and not run_name/checkpoint-xxx within GCS_MODEL_EVAL_DIR. We now fix it to save to run_name/checkpoint-xxx


          updated gcs_eval_checkpoints.py to save tokenizer if it is missing fr…

e4bdab6

…om checkpoint directory

fixed bug on directory when moving

rishsriv force-pushed the jp/gcs branch from 1cb5103 to e4bdab6 Compare

May 17, 2024 07:06

wongjingping requested a review from wendy-aw

May 17, 2024 07:19

rishsriv approved these changes

View reviewed changes

Member

rishsriv left a comment

Thanks for the fix!

rishsriv merged commit 7aec2c5 into main

2 checks passed

rishsriv deleted the jp/gcs branch

May 17, 2024 07:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet