Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and parsing fixes #130

Merged
merged 1 commit into from
May 8, 2024
Merged

Query and parsing fixes #130

merged 1 commit into from
May 8, 2024

Conversation

wongjingping
Copy link
Collaborator

fix erroneous sql (no columns required within GROUP BY {})
add stop characters to facilitate parsing from other prompt formats
update tests with an extra case testing GROUP BY {} expansion

add stop characters
update tests with an extra case
@wongjingping wongjingping marked this pull request as ready for review May 8, 2024 08:08
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thanks for the fixes, and the test :D

@rishsriv rishsriv merged commit 7331608 into main May 8, 2024
2 checks passed
@rishsriv rishsriv deleted the jp/fixes branch May 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants