Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a few edge cases while shuffling #9

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fixing a few edge cases while shuffling #9

merged 1 commit into from
Jun 10, 2024

Conversation

wongjingping
Copy link
Contributor

@wongjingping wongjingping commented Jun 10, 2024

Fixing a few edge cases while shuffling.
The main error here is how the section before the comment (if present) could contain more than 1 comma (eg ytd_return numeric(10,2),), and if we just check for trailing commas using "," in col that would give false positives in the following case:

col = "  ytd_return numeric(10,2)"
"," in col
# returns True but there is no trailing comma!

Also added tests for fix_comma since that's where the comma fixing happens.

Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah GREAT find! Thanks for the fix :D

@wongjingping wongjingping merged commit 9d7660c into main Jun 10, 2024
1 check passed
@wongjingping wongjingping deleted the jp/fixc branch June 10, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants