Update Sqlglot and fix regression #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add additional test using column names with spaces
|
Hmm I'm not quite sure why that test is failing though 🤷🏽♂️ |
|
Turns out that after bumping sqlglot to the latest version 25.8.1, p.s. sqlglot parsing for TO_DATE in postgres was updated in the original repo here ~ 2 weeks ago |
wongjingping
commented
Aug 5, 2024
| @@ -429,6 +429,8 @@ def get_sql_features( | |||
| features.date_sub = True | |||
| elif isinstance(node, exp.DateTrunc) or isinstance(node, exp.TimestampTrunc): | |||
| features.date_trunc = True | |||
| elif isinstance(node, exp.StrToDate): | |||
There was a problem hiding this comment.
this is the key regression fix after updating sqlglot
There was a problem hiding this comment.
Thank you for documenting and for the fix!
wongjingping
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinned sqlglot version in requirements.txt
fixed featurization of
TO_DATEwhendialect="postgres"linted repo
add additional test using column names with spaces
add vscode settings to facilitate easier testing