-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: #491 support arm64 (Apple Silicon) #659
Merged
Merged
+339
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be platform agnostic Update .gitignore
…d. Also modify the supabase chart values to not specify image versions in order to prevent versioning drift from the base chart (reduces number of places we need to change to just be the images in the zarf.yaml)
✅ Deploy Preview for leapfrogai-docs canceled.
|
Remove dangling unnecesary make targets
…to simplify the ci build without a divergent pattern, as well as allow quicker dev iteration on docker builds
Add some formatting to README.md to make it hopefully more readable and clear Remove duplicate .dockerignore entries
…tignore copied section
gphorvath
reviewed
Jun 19, 2024
gphorvath
reviewed
Jun 19, 2024
This seems to deploy well on my Mac, although we need to resolve the issues with the e2e pipeline failing. |
Closed
# Conflicts: # README.md
gphorvath
previously approved these changes
Jul 2, 2024
YrrepNoj
reviewed
Jul 2, 2024
Fix issue with README.md changes
…' into 491-markv-apple-sillicon-support
Tested on MacOS and Ubuntu (for testing vLLM build refactor) |
…into 491-markv-apple-sillicon-support
gphorvath
previously approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still deploys well on my Mac! Still have some blocking feedback on here from @YrrepNoj though.
alekst23
added this to the Current - RAG UX Enhancements | Model Directory | API Odds and Ends milestone
Jul 11, 2024
gphorvath
approved these changes
Jul 12, 2024
justinthelaw
approved these changes
Jul 12, 2024
YrrepNoj
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.