Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #491 support arm64 (Apple Silicon) #659

Merged
merged 30 commits into from
Jul 12, 2024

Conversation

vanakema
Copy link
Contributor

No description provided.

vanakema added 4 commits June 18, 2024 12:42
…d. Also modify the supabase chart values to not specify image versions in order to prevent versioning drift from the base chart (reduces number of places we need to change to just be the images in the zarf.yaml)
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 311c389
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/6691952c62a96b00089b4acc

vanakema added 6 commits June 18, 2024 15:38
…to simplify the ci build without a divergent pattern, as well as allow quicker dev iteration on docker builds
Add some formatting to README.md to make it hopefully more readable and clear
Remove duplicate .dockerignore entries
@vanakema vanakema marked this pull request as ready for review June 18, 2024 23:33
@vanakema vanakema requested a review from a team as a code owner June 18, 2024 23:33
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gphorvath
Copy link

This seems to deploy well on my Mac, although we need to resolve the issues with the e2e pipeline failing.

@vanakema vanakema requested review from gphorvath and a team June 21, 2024 23:01
@CollectiveUnicorn CollectiveUnicorn removed their request for review July 2, 2024 17:31
gphorvath
gphorvath previously approved these changes Jul 2, 2024
Makefile Outdated Show resolved Hide resolved
src/leapfrogai_sdk/Dockerfile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
packages/supabase/zarf.yaml Show resolved Hide resolved
packages/whisper/Dockerfile Show resolved Hide resolved
@vanakema
Copy link
Contributor Author

vanakema commented Jul 9, 2024

Tested on MacOS and Ubuntu (for testing vLLM build refactor)

gphorvath
gphorvath previously approved these changes Jul 11, 2024
Copy link

@gphorvath gphorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still deploys well on my Mac! Still have some blocking feedback on here from @YrrepNoj though.

@justinthelaw justinthelaw self-requested a review July 12, 2024 20:03
@YrrepNoj YrrepNoj enabled auto-merge (squash) July 12, 2024 20:36
@YrrepNoj YrrepNoj merged commit adf3334 into main Jul 12, 2024
15 checks passed
@YrrepNoj YrrepNoj deleted the 491-markv-apple-sillicon-support branch July 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants