Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the linux binary to xdg-open #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 21 additions & 44 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"projectName": "vscode-dash",
"projectOwner": "deerawan",
"files": [
"README.md"
],
"files": ["README.md"],
"imageSize": 100,
"commit": true,
"contributors": [
Expand All @@ -12,115 +10,94 @@
"name": "Budi Irawan",
"avatar_url": "https://avatars1.githubusercontent.com/u/1243921?v=4",
"profile": "http://budiirawan.com",
"contributions": [
"code",
"doc"
]
"contributions": ["code", "doc"]
},
{
"login": "profelis",
"name": "Dima Granetchi",
"avatar_url": "https://avatars0.githubusercontent.com/u/250935?v=4",
"profile": "https://github.com/profelis",
"contributions": [
"code",
"doc"
]
"contributions": ["code", "doc"]
},
{
"login": "loganintech",
"name": "Logan Saso",
"avatar_url": "https://avatars2.githubusercontent.com/u/6226408?v=4",
"profile": "https://github.com/loganintech",
"contributions": [
"code",
"doc"
]
"contributions": ["code", "doc"]
},
{
"login": "szhongren",
"name": "Zhongren Shao",
"avatar_url": "https://avatars3.githubusercontent.com/u/8567599?v=4",
"profile": "https://github.com/szhongren",
"contributions": [
"code",
"doc"
]
"contributions": ["code", "doc"]
},
{
"login": "weifding",
"name": "dingweifeng",
"avatar_url": "https://avatars1.githubusercontent.com/u/5329046?v=4",
"profile": "https://github.com/weifding",
"contributions": [
"doc"
]
"contributions": ["doc"]
},
{
"login": "sbromberger",
"name": "Seth Bromberger",
"avatar_url": "https://avatars0.githubusercontent.com/u/941359?v=4",
"profile": "http://www.bromberger.com",
"contributions": [
"code",
"doc"
]
"contributions": ["code", "doc"]
},
{
"login": "br1anchen",
"name": "br1anchen",
"avatar_url": "https://avatars2.githubusercontent.com/u/1086461?v=4",
"profile": "https://github.com/br1anchen",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "cmygray",
"name": "Won Kim",
"avatar_url": "https://avatars3.githubusercontent.com/u/26966551?v=4",
"profile": "https://medium.com/@cmygray",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "salembeats",
"name": "Cuyler Stuwe",
"avatar_url": "https://avatars0.githubusercontent.com/u/20496944?v=4",
"profile": "https://www.upwork.com/fl/cuylerstuwe",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "ozylog",
"name": "Cahya Pribadi",
"avatar_url": "https://avatars3.githubusercontent.com/u/534150?v=4",
"profile": "https://ozylog.com",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "markokajzer",
"name": "Marko Kajzer",
"avatar_url": "https://avatars3.githubusercontent.com/u/9379317?v=4",
"profile": "https://github.com/markokajzer",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "akdir",
"name": "akdir",
"avatar_url": "https://avatars0.githubusercontent.com/u/19649463?v=4",
"profile": "https://github.com/akdir",
"contributions": [
"code"
]
"contributions": ["code"]
},
{
"login": "Abrifq",
"name": "Arda Aydın",
"avatar_url": "https://avatars.githubusercontent.com/u/30421526?v=4",
"profile": "https://github.com/Abrifq",
"contributions": ["code"]
}
],
"repoType": "github",
"commitConvention": "none"
}

37 changes: 20 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,25 +165,28 @@ Thank you for these awesome contributors
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tr>
<td align="center"><a href="http://budiirawan.com"><img src="https://avatars1.githubusercontent.com/u/1243921?v=4" width="100px;" alt="Budi Irawan"/><br /><sub><b>Budi Irawan</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=deerawan" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=deerawan" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/profelis"><img src="https://avatars0.githubusercontent.com/u/250935?v=4" width="100px;" alt="Dima Granetchi"/><br /><sub><b>Dima Granetchi</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=profelis" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=profelis" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/loganintech"><img src="https://avatars2.githubusercontent.com/u/6226408?v=4" width="100px;" alt="Logan Saso"/><br /><sub><b>Logan Saso</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=loganintech" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=loganintech" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/szhongren"><img src="https://avatars3.githubusercontent.com/u/8567599?v=4" width="100px;" alt="Zhongren Shao"/><br /><sub><b>Zhongren Shao</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=szhongren" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=szhongren" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/weifding"><img src="https://avatars1.githubusercontent.com/u/5329046?v=4" width="100px;" alt="dingweifeng"/><br /><sub><b>dingweifeng</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=weifding" title="Documentation">📖</a></td>
<td align="center"><a href="http://www.bromberger.com"><img src="https://avatars0.githubusercontent.com/u/941359?v=4" width="100px;" alt="Seth Bromberger"/><br /><sub><b>Seth Bromberger</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=sbromberger" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=sbromberger" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/br1anchen"><img src="https://avatars2.githubusercontent.com/u/1086461?v=4" width="100px;" alt="br1anchen"/><br /><sub><b>br1anchen</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=br1anchen" title="Code">💻</a></td>
</tr>
<tr>
<td align="center"><a href="https://medium.com/@cmygray"><img src="https://avatars3.githubusercontent.com/u/26966551?v=4" width="100px;" alt="Won Kim"/><br /><sub><b>Won Kim</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=cmygray" title="Code">💻</a></td>
<td align="center"><a href="https://www.upwork.com/fl/cuylerstuwe"><img src="https://avatars0.githubusercontent.com/u/20496944?v=4" width="100px;" alt="Cuyler Stuwe"/><br /><sub><b>Cuyler Stuwe</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=salembeats" title="Code">💻</a></td>
<td align="center"><a href="https://ozylog.com"><img src="https://avatars3.githubusercontent.com/u/534150?v=4" width="100px;" alt="Cahya Pribadi"/><br /><sub><b>Cahya Pribadi</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=ozylog" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/markokajzer"><img src="https://avatars3.githubusercontent.com/u/9379317?v=4" width="100px;" alt="Marko Kajzer"/><br /><sub><b>Marko Kajzer</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=markokajzer" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/akdir"><img src="https://avatars0.githubusercontent.com/u/19649463?v=4" width="100px;" alt="akdir"/><br /><sub><b>akdir</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=akdir" title="Code">💻</a></td>
</tr>
<tbody>
<tr>
<td align="center" valign="top" width="14.28%"><a href="http://budiirawan.com"><img src="https://avatars1.githubusercontent.com/u/1243921?v=4?s=100" width="100px;" alt="Budi Irawan"/><br /><sub><b>Budi Irawan</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=deerawan" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=deerawan" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/profelis"><img src="https://avatars0.githubusercontent.com/u/250935?v=4?s=100" width="100px;" alt="Dima Granetchi"/><br /><sub><b>Dima Granetchi</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=profelis" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=profelis" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/loganintech"><img src="https://avatars2.githubusercontent.com/u/6226408?v=4?s=100" width="100px;" alt="Logan Saso"/><br /><sub><b>Logan Saso</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=loganintech" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=loganintech" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/szhongren"><img src="https://avatars3.githubusercontent.com/u/8567599?v=4?s=100" width="100px;" alt="Zhongren Shao"/><br /><sub><b>Zhongren Shao</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=szhongren" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=szhongren" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/weifding"><img src="https://avatars1.githubusercontent.com/u/5329046?v=4?s=100" width="100px;" alt="dingweifeng"/><br /><sub><b>dingweifeng</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=weifding" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://www.bromberger.com"><img src="https://avatars0.githubusercontent.com/u/941359?v=4?s=100" width="100px;" alt="Seth Bromberger"/><br /><sub><b>Seth Bromberger</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=sbromberger" title="Code">💻</a> <a href="https://github.com/deerawan/vscode-dash/commits?author=sbromberger" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/br1anchen"><img src="https://avatars2.githubusercontent.com/u/1086461?v=4?s=100" width="100px;" alt="br1anchen"/><br /><sub><b>br1anchen</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=br1anchen" title="Code">💻</a></td>
</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://medium.com/@cmygray"><img src="https://avatars3.githubusercontent.com/u/26966551?v=4?s=100" width="100px;" alt="Won Kim"/><br /><sub><b>Won Kim</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=cmygray" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.upwork.com/fl/cuylerstuwe"><img src="https://avatars0.githubusercontent.com/u/20496944?v=4?s=100" width="100px;" alt="Cuyler Stuwe"/><br /><sub><b>Cuyler Stuwe</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=salembeats" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://ozylog.com"><img src="https://avatars3.githubusercontent.com/u/534150?v=4?s=100" width="100px;" alt="Cahya Pribadi"/><br /><sub><b>Cahya Pribadi</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=ozylog" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/markokajzer"><img src="https://avatars3.githubusercontent.com/u/9379317?v=4?s=100" width="100px;" alt="Marko Kajzer"/><br /><sub><b>Marko Kajzer</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=markokajzer" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/akdir"><img src="https://avatars0.githubusercontent.com/u/19649463?v=4?s=100" width="100px;" alt="akdir"/><br /><sub><b>akdir</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=akdir" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Abrifq"><img src="https://avatars.githubusercontent.com/u/30421526?v=4?s=100" width="100px;" alt="Arda Aydın"/><br /><sub><b>Arda Aydın</b></sub></a><br /><a href="https://github.com/deerawan/vscode-dash/commits?author=Abrifq" title="Code">💻</a></td>
</tr>
</tbody>
</table>

<!-- markdownlint-enable -->
<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->
Expand Down
3 changes: 2 additions & 1 deletion src/dash.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const OSOptions: OSOptions = {
darwin: 'open -g',
linux: 'zeal',
//Allows any dash compatible program to handle the request, even on flatpak.
linux: 'xdg-open',
// Same technique as Silverlake Software's "Search Docsets" extension,
// which is written by Velocity's developer and is tested to work with current Velocity on W10.
win32: 'cmd.exe /c start "" ', // TODO: do we need extra space?
Expand Down