-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uwsgi integration #11
base: master
Are you sure you want to change the base?
Conversation
@fidelram this will make HiCB working under uwsgi, which is used in the Docker container and in Galaxy. |
Remove all slashes and directory traversing
With respect to views.py I don't see much problems but I have not tested them (@bgruening does it run for you?). For the other edits I have to warn you that some of the code modified, like App.js, is generated by Node.js Thus, ideally, such things should be removed at the source code and the the new js code should be recompiled. However, I only have a superficial understanding of how this works and the main developer is not longer available. Do you know any Node.js guru? |
I see. Yes it is working for us and it will be part of the next upcoming Galaxy release. One thing this PR is also doing is that you can now run multiple visualizations under different sub-dirs. Like foo.eu/human and foo.eu/mouse. This will be useful for the Hein group. |
Different subdirs will be quite useful for us as well. Something that I think is not working for me in the current version is the search by gene name. Is it working for you? |
This branch is used in the HiCBrowser Docker image, as we are using nginx as proxy server and uwsgi as application server inside of the image.
Unfortunately, I was not able to get uwsgi and the
./runBrowserpy
script working simultaneously. Theapp
has some wired behaviors so I needed to include the main call in the views.py script.I hope someone is more a flask expert and can help resolving this. Until than I will leave this PR open and update this branch manually with the master branch if needed.