Skip to content

CI: prefer bf16 over fp16 #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

CI: prefer bf16 over fp16 #7304

wants to merge 2 commits into from

Conversation

stas00
Copy link
Collaborator

@stas00 stas00 commented May 22, 2025 •
edited
Loading

these days fp16 is barely ever used, so we should be testing bf16 instead of fp16 where possible.

edit: looks like 3 tests have a hardcoded fp16 dtype and fail when changing to bf16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-truwase sfc-gh-truwase sfc-gh-truwase approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase will be requested when the pull request is marked ready for review tjruwase is a code owner

@loadams loadams Awaiting requested review from loadams loadams will be requested when the pull request is marked ready for review loadams is a code owner

@tohtana tohtana Awaiting requested review from tohtana tohtana will be requested when the pull request is marked ready for review tohtana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas00 @sfc-gh-truwase