Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: NLTKDocumentSplitter: add 'function' to split_by init param #8378

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: NLTKDocumentSplitter: add 'function' to split_by init param #8378

merged 1 commit into from
Sep 17, 2024

Conversation

vblagoje
Copy link
Member

  • Fixes failed linter on the NLTKDocumentSplitter
  • Failure showed up because NLTKDocumentSplitter extends DocumentSplitter and DocumentSplitter init method was changed on main after NLTKDocumentSplitter PR was opened
  • Merge PRs to main before merge-ing!

@vblagoje vblagoje requested a review from a team as a code owner September 17, 2024 12:39
@vblagoje vblagoje requested review from davidsbatista and removed request for a team September 17, 2024 12:40
@vblagoje vblagoje added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 17, 2024
@vblagoje
Copy link
Member Author

Let's see that CI runs green as well
cc @shadeMe

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10904241636

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.388%
Totals Coverage Status
Change from base Build 10902548715: 0.0%
Covered Lines: 7335
Relevant Lines: 8115
💛 - Coveralls

@vblagoje vblagoje merged commit 117c298 into main Sep 17, 2024
15 checks passed
@vblagoje vblagoje deleted the fix_nltk_splitter branch September 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vblagoje @coveralls @davidsbatista