Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move AnswerJoiner pipeline test to behavorial tests #8377

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 17, 2024

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner September 17, 2024 11:45
@sjrl sjrl requested review from julian-risch and removed request for a team September 17, 2024 11:45
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10902356165

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.267%

Totals Coverage Status
Change from base Build 10902348484: 0.0%
Covered Lines: 7160
Relevant Lines: 7932

💛 - Coveralls

@julian-risch julian-risch added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 17, 2024
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 It's much better to test this component without an OpenAI API key and in the behavioral tests.

@julian-risch julian-risch merged commit 2235ce6 into main Sep 19, 2024
19 of 20 checks passed
@julian-risch julian-risch deleted the consolidate-pipeline-tests branch September 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants