Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent set_output_types from being called when the output_types decorator is used #8376

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: Prevent set_output_types from being called when the output_types decorator is used #8376

merged 1 commit into from
Sep 18, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Sep 17, 2024

Related Issues

How did you test it?

CI

Checklist

@shadeMe shadeMe requested a review from a team as a code owner September 17, 2024 11:23
@shadeMe shadeMe requested review from anakin87 and removed request for a team September 17, 2024 11:23
@shadeMe shadeMe force-pushed the fix/component-set-output-types-override branch from f466337 to 881817c Compare September 17, 2024 11:24
@shadeMe shadeMe requested a review from a team as a code owner September 17, 2024 11:24
@shadeMe shadeMe requested review from dfokina and silvanocerza and removed request for a team and anakin87 September 17, 2024 11:24
@shadeMe shadeMe force-pushed the fix/component-set-output-types-override branch from 881817c to b09c123 Compare September 17, 2024 12:29
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10903048626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 90.391%
Files with Coverage Reduction New Missed Lines %
components/classifiers/zero_shot_document_classifier.py 3 91.07%
Totals Coverage Status
Change from base Build 10902548715: 0.003%
Covered Lines: 7337
Relevant Lines: 8117
💛 - Coveralls

@shadeMe shadeMe merged commit b22014b into deepset-ai:main Sep 18, 2024
18 checks passed
@shadeMe shadeMe deleted the fix/component-set-output-types-override branch September 18, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:core topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

component.set_output_types() overrides @component.output_types() if both are used in the same Component
3 participants
@shadeMe @coveralls @silvanocerza