refactor: Rename Component.async_run to Component.run_async for better readablility
#8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeMe
requested review from
dfokina and
silvanocerza
and removed request for
a team
Pull Request Test Coverage Report for Build 10900657906Details
💛 - Coveralls |
…etter readablility Using a suffix will keep names logically sorted, less noisy and relegate the async aspect to an implementation/API detail.
shadeMe
force-pushed
the
refactor/rename-async-run
branch
from
89db502 to
e342da4
Compare
shadeMe
added
the
ignore-for-release-notes
silvanocerza
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Using a suffix will keep names logically sorted, less noisy and relegate the async aspect to an implementation/API detail.
How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.